NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit668e37d

committed

Fix wrong WAL info value generated when gistContinueInsert() performs an

index page split. This would result in index corruption, or even more likelyan error during WAL replay, if we were unlucky enough to crash duringend-of-recovery cleanup after having completed an incomplete GIST insertion.Yoichi Hirai

1 parent98e8a41 commit668e37dCopy full SHA for 668e37d

File tree

1 file changed

-2

lines changed

src/backend/access/gist
- gistxlog.c

1 file changed

-2

lines changed

`‎src/backend/access/gist/gistxlog.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,7 @@`
`8`	`8`	`* Portions Copyright (c) 1994, Regents of the University of California`
`9`	`9`	`*`
`10`	`10`	`* IDENTIFICATION`
`11`		`- * $PostgreSQL: pgsql/src/backend/access/gist/gistxlog.c,v 1.33 2009/12/19 01:32:32 sriggs Exp $`
	`11`	`+ * $PostgreSQL: pgsql/src/backend/access/gist/gistxlog.c,v 1.34 2009/12/24 17:52:04 tgl Exp $`
`12`	`12`	`*-------------------------------------------------------------------------`
`13`	`13`	`*/`
`14`	`14`	`#include"postgres.h"`
`@@ -650,6 +650,7 @@ gistContinueInsert(gistIncompleteInsert *insert)`
`650`	`650`	`intj,`
`651`	`651`	`k,`
`652`	`652`	`pituplen=0;`
	`653`	`+uint8xlinfo;`
`653`	`654`	`XLogRecData*rdata;`
`654`	`655`	`XLogRecPtrrecptr;`
`655`	`656`	`Buffertempbuffer=InvalidBuffer;`
`@@ -738,6 +739,7 @@ gistContinueInsert(gistIncompleteInsert *insert)`
`738`	`739`	`for (j=0;j<ntodelete;j++)`
`739`	`740`	`PageIndexTupleDelete(pages[0],todelete[j]);`
`740`	`741`
	`742`	`+xlinfo=XLOG_GIST_PAGE_SPLIT;`
`741`	`743`	`rdata=formSplitRdata(index->rd_node,insert->path[i],`
`742`	`744`	`false,&(insert->key),`
`743`	`745`	`gistMakePageLayout(buffers,numbuffer));`
`@@ -751,6 +753,7 @@ gistContinueInsert(gistIncompleteInsert *insert)`
`751`	`753`	`PageIndexTupleDelete(pages[0],todelete[j]);`
`752`	`754`	`gistfillbuffer(pages[0],itup,lenitup,InvalidOffsetNumber);`
`753`	`755`
	`756`	`+xlinfo=XLOG_GIST_PAGE_UPDATE;`
`754`	`757`	`rdata=formUpdateRdata(index->rd_node,buffers[0],`
`755`	`758`	`todelete,ntodelete,`
`756`	`759`	`itup,lenitup,&(insert->key));`
`@@ -767,7 +770,7 @@ gistContinueInsert(gistIncompleteInsert *insert)`
`767`	`770`	`GistPageGetOpaque(pages[j])->rightlink=InvalidBlockNumber;`
`768`	`771`	`MarkBufferDirty(buffers[j]);`
`769`	`772`	`}`
`770`		`-recptr=XLogInsert(RM_GIST_ID,XLOG_GIST_PAGE_UPDATE,rdata);`
	`773`	`+recptr=XLogInsert(RM_GIST_ID,xlinfo,rdata);`
`771`	`774`	`for (j=0;j<numbuffer;j++)`
`772`	`775`	`{`
`773`	`776`	`PageSetLSN(pages[j],recptr);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit668e37d

File tree

1 file changed

1 file changed

`‎src/backend/access/gist/gistxlog.c`

0 commit comments