NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit665ca54

committed

Fix mistake inbbe08b8.

The earlier commit used pg_class.relfilenode where it should haveused pg_class.oid. This could lead to emitting an UPDATE statementinto the dump that would update nothing (or the wrong thing) whenexecuted in the new cluster, resulting in relfrozenxid andrelminmxid being improperly carried forward for pg_largeobject.Noticed by Dilip Kumar.Discussion:http://postgr.es/m/CAFiTN-ty1Gzs6stk2vt9BJiq0m0hzf=aPnh3a-4Z3Tk5GzoENw@mail.gmail.com

1 parent798d644 commit665ca54Copy full SHA for 665ca54

File tree

1 file changed

-1

lines changed

src/bin/pg_dump
- pg_dump.c

1 file changed

-1

lines changed

`‎src/bin/pg_dump/pg_dump.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -3180,7 +3180,7 @@ dumpDatabase(Archive *fout)`
`3180`	`3180`	`"WHERE oid = %u;\n",`
`3181`	`3181`	`atooid(PQgetvalue(lo_res, i, i_relfrozenxid)),`
`3182`	`3182`	`atooid(PQgetvalue(lo_res, i, i_relminmxid)),`
`3183`		`- atooid(PQgetvalue(lo_res, i,i_relfilenode)));`
	`3183`	`+ atooid(PQgetvalue(lo_res, i,i_oid)));`
`3184`	`3184`
`3185`	`3185`	`oid = atooid(PQgetvalue(lo_res, i, i_oid));`
`3186`	`3186`	`relfilenode = atooid(PQgetvalue(lo_res, i, i_relfilenode));`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit665ca54

File tree

1 file changed

1 file changed

`‎src/bin/pg_dump/pg_dump.c`

0 commit comments