Commit665785d

committed

Fix unnecessary casts of copyObject() result

The result is already of the correct type, so these casts don't doanything.Reviewed-by: Nathan Bossart <nathandbossart@gmail.com>Reviewed-by: Tender Wang <tndrwang@gmail.com>Discussion:https://www.postgresql.org/message-id/flat/637eeea8-5663-460b-a114-39572c0f6c6e%40eisentraut.org

1 parenteafda78 commit665785dCopy full SHA for 665785d

File tree

-4

lines changed

-4

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1169,7 +1169,7 @@ CreateTriggerFiringOn(CreateTrigStmt stmt, const char queryString,`
`1169`	`1169`	`* Initialize our fabricated parse node by copying the original`
`1170`	`1170`	`* one, then resetting fields that we pass separately.`
`1171`	`1171`	`*/`
`1172`		`-childStmt=(CreateTrigStmt*)copyObject(stmt);`
	`1172`	`+childStmt=copyObject(stmt);`
`1173`	`1173`	`childStmt->funcname=NIL;`
`1174`	`1174`	`childStmt->whenClause=NULL;`
`1175`	`1175`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2996,7 +2996,7 @@ expression_tree_mutator_impl(Node *node,`
`2996`	`2996`	`caseT_SortGroupClause:`
`2997`	`2997`	`caseT_CTESearchClause:`
`2998`	`2998`	`caseT_MergeSupportFunc:`
`2999`		`-return(Node*)copyObject(node);`
	`2999`	`+returncopyObject(node);`
`3000`	`3000`	`caseT_WithCheckOption:`
`3001`	`3001`	`{`
`3002`	`3002`	`WithCheckOptionwco= (WithCheckOption)node;`
`@@ -3604,7 +3604,7 @@ expression_tree_mutator_impl(Node *node,`
`3604`	`3604`	`break;`
`3605`	`3605`	`caseT_PartitionPruneStepCombine:`
`3606`	`3606`	`/* no expression sub-nodes */`
`3607`		`-return(Node*)copyObject(node);`
	`3607`	`+returncopyObject(node);`
`3608`	`3608`	`caseT_JoinExpr:`
`3609`	`3609`	`{`
`3610`	`3610`	`JoinExprjoin= (JoinExpr)node;`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1715,7 +1715,7 @@ ReplaceVarsFromTargetList_callback(Var *var,`
`1715`	`1715`	`break;`
`1716`	`1716`
`1717`	`1717`	`caseREPLACEVARS_CHANGE_VARNO:`
`1718`		`-var=(Var*)copyObject(var);`
	`1718`	`+var=copyObject(var);`
`1719`	`1719`	`var->varno=rcon->nomatch_varno;`
`1720`	`1720`	`/* we leave the syntactic referent alone */`
`1721`	`1721`	`return (Node*)var;`

Comments

(0)