Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6608a43

Browse files
committed
Be more wary about 32-bit integer overflow in pg_stat_statements.
We've heard a couple of reports of people having trouble withmulti-gigabyte-sized query-texts files. It occurred to me that on32-bit platforms, there could be an issue with integer overflowof calculations associated with the total query text size.Address that with several changes:1. Limit pg_stat_statements.max to INT_MAX / 2 not INT_MAX.The hashtable code will bound it to that anyway unless "long"is 64 bits. We still need overflow guards on its use, butthis helps.2. Add a check to prevent extending the query-texts file tomore than MaxAllocHugeSize. If it got that big, qtext_load_filewould certainly fail, so there's not much point in allowing it.Without this, we'd need to consider whether extent, query_offset,and related variables shouldn't be off_t not size_t.3. Adjust the comparisons in need_gc_qtexts() to be done in 64-bitarithmetic on all platforms. It appears possible that under duressthose multiplications could overflow 32 bits, yielding a falseconclusion that we need to garbage-collect the texts file, whichcould lead to repeatedly garbage-collecting after every hash tableinsertion.Per report from Bruno da Silva. I'm not convinced that theseissues fully explain his problem; there may be some other bug that'scontributing to the query-texts file becoming so large in the firstplace. But it did get that big, so#2 is a reasonable defense,and#3 could explain the reported performance difficulties.(See also commit8bbe4cb, which addressed some related bugs.The second Discussion: link is the thread that led up to that.)This issue is old, and is primarily a problem for old platforms,so back-patch.Discussion:https://postgr.es/m/CAB+Nuk93fL1Q9eLOCotvLP07g7RAv4vbdrkm0cVQohDVMpAb9A@mail.gmail.comDiscussion:https://postgr.es/m/5601D354.5000703@BlueTreble.com
1 parent5d280bc commit6608a43

File tree

1 file changed

+22
-4
lines changed

1 file changed

+22
-4
lines changed

‎contrib/pg_stat_statements/pg_stat_statements.c

Lines changed: 22 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -368,7 +368,7 @@ _PG_init(void)
368368
&pgss_max,
369369
5000,
370370
100,
371-
INT_MAX,
371+
INT_MAX /2,
372372
PGC_POSTMASTER,
373373
0,
374374
NULL,
@@ -1869,6 +1869,18 @@ qtext_store(const char *query, int query_len,
18691869

18701870
*query_offset=off;
18711871

1872+
/*
1873+
* Don't allow the file to grow larger than what qtext_load_file can
1874+
* (theoretically) handle. This has been seen to be reachable on 32-bit
1875+
* platforms.
1876+
*/
1877+
if (unlikely(query_len >=MaxAllocHugeSize-off))
1878+
{
1879+
errno=EFBIG;/* not quite right, but it'll do */
1880+
fd=-1;
1881+
gotoerror;
1882+
}
1883+
18721884
/* Now write the data into the successfully-reserved part of the file */
18731885
fd=OpenTransientFile(PGSS_TEXT_FILE,O_RDWR |O_CREAT |PG_BINARY);
18741886
if (fd<0)
@@ -2057,8 +2069,14 @@ need_gc_qtexts(void)
20572069
SpinLockRelease(&s->mutex);
20582070
}
20592071

2060-
/* Don't proceed if file does not exceed 512 bytes per possible entry */
2061-
if (extent<512*pgss_max)
2072+
/*
2073+
* Don't proceed if file does not exceed 512 bytes per possible entry.
2074+
*
2075+
* Here and in the next test, 32-bit machines have overflow hazards if
2076+
* pgss_max and/or mean_query_len are large. Force the multiplications
2077+
* and comparisons to be done in uint64 arithmetic to forestall trouble.
2078+
*/
2079+
if ((uint64)extent< (uint64)512*pgss_max)
20622080
return false;
20632081

20642082
/*
@@ -2068,7 +2086,7 @@ need_gc_qtexts(void)
20682086
* query length in order to prevent garbage collection from thrashing
20692087
* uselessly.
20702088
*/
2071-
if (extent<pgss->mean_query_len*pgss_max*2)
2089+
if ((uint64)extent< (uint64)pgss->mean_query_len*pgss_max*2)
20722090
return false;
20732091

20742092
return true;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp