Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit65e8dbb

Browse files
committed
Fix bug in clean shutdown of walsender that pg_receiving is connecting to.
On clean shutdown, walsender waits for all WAL to be replicated to a standby,and exits. It determined whether that replication had been completed bychecking whether its sent location had been equal to a standby's flushlocation. Unfortunately this condition never becomes true when the standbysuch as pg_receivexlog which always returns an invalid flush location isconnecting to walsender, and then walsender waits forever.This commit changes walsender so that it just checks a standby's writelocation if a flush location is invalid.Back-patch to 9.1 where enough infrastructure for this exists.
1 parentf84997c commit65e8dbb

File tree

1 file changed

+12
-1
lines changed

1 file changed

+12
-1
lines changed

‎src/backend/replication/walsender.c

Lines changed: 12 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -775,9 +775,20 @@ WalSndLoop(void)
775775
*/
776776
if (walsender_ready_to_stop)
777777
{
778+
XLogRecPtrreplicatedPtr;
779+
778780
/* ... let's just be real sure we're caught up ... */
779781
XLogSend(output_message,&caughtup);
780-
if (caughtup&&XLByteEQ(sentPtr,MyWalSnd->flush)&&
782+
783+
/*
784+
* Check a write location to see whether all the WAL have
785+
* successfully been replicated if this walsender is connecting
786+
* to a standby such as pg_receivexlog which always returns
787+
* an invalid flush location. Otherwise, check a flush location.
788+
*/
789+
replicatedPtr=XLogRecPtrIsInvalid(MyWalSnd->flush) ?
790+
MyWalSnd->write :MyWalSnd->flush;
791+
if (caughtup&&XLByteEQ(sentPtr,replicatedPtr)&&
781792
!pq_is_send_pending())
782793
{
783794
walsender_shutdown_requested= true;

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp