Commit65df150

committed

Close replication connection when slot creation errors

From: Petr Jelinek <pjmodos@pjmodos.net>

1 parentaebeb47 commit65df150Copy full SHA for 65df150

File tree

+14

-4

lines changed

+14

-4

lines changed

Lines changed: 14 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -301,10 +301,20 @@ CreateSubscription(CreateSubscriptionStmt *stmt)`
`301`	`301`	`ereport(ERROR,`
`302`	`302`	`(errmsg("could not connect to the publisher: %s",err)));`
`303`	`303`
`304`		`-walrcv_create_slot(wrconn,slotname, false,&lsn);`
`305`		`-ereport(NOTICE,`
`306`		`-(errmsg("created replication slot \"%s\" on publisher",`
`307`		`-slotname)));`
	`304`	`+PG_TRY();`
	`305`	`+{`
	`306`	`+walrcv_create_slot(wrconn,slotname, false,&lsn);`
	`307`	`+ereport(NOTICE,`
	`308`	`+(errmsg("created replication slot \"%s\" on publisher",`
	`309`	`+slotname)));`
	`310`	`+}`
	`311`	`+PG_CATCH();`
	`312`	`+{`
	`313`	`+/* Close the connection in case of failure. */`
	`314`	`+walrcv_disconnect(wrconn);`
	`315`	`+PG_RE_THROW();`
	`316`	`+}`
	`317`	`+PG_END_TRY();`
`308`	`318`
`309`	`319`	`/* And we are done with the remote side. */`
`310`	`320`	`walrcv_disconnect(wrconn);`

Comments

(0)