NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6593c5b

committed

Fix bug in freespace calculation in heap_multi_insert().

If the amount of freespace on page was less than the amount reserved byfillfactor, the calculation would underflow.This fixes bug #6643 reported by Tomonari Katsumata.

1 parent00b0c73 commit6593c5bCopy full SHA for 6593c5b

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2159,7 +2159,7 @@ heap_multi_insert(Relation relation, HeapTuple *tuples, int ntuples,`
`2159`	`2159`	`{`
`2160`	`2160`	`HeapTupleheaptup=heaptuples[ndone+nthispage];`
`2161`	`2161`
`2162`		`-if (PageGetHeapFreeSpace(page)-saveFreeSpace<MAXALIGN(heaptup->t_len))`
	`2162`	`+if (PageGetHeapFreeSpace(page)<MAXALIGN(heaptup->t_len)+saveFreeSpace)`
`2163`	`2163`	`break;`
`2164`	`2164`
`2165`	`2165`	`RelationPutHeapTuple(relation,buffer,heaptup);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6593c5b

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments