NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit64e77b4

committed

pgbench: Fix overflow in table populating when rows >= 2^31-1

Using a scale factor large enough so as the number of rows to insertgets larger than INT32_MAX would cause an infinite loop ininitPopulateTable(), preventing pgbench to finish its initialization.Oversight ine35cc3b that has refactored the data generation logic.Author: John HsuReviewed-by: Tatsuo Ishii, Japin LiDiscussion:https://postgr.es/m/CA+-JvFvHsOafjHcuFPfkyouHNZvbOXhBNhwZxKm3WNgYz9bwzA@mail.gmail.com

1 parentda44ff3 commit64e77b4Copy full SHA for 64e77b4

File tree

1 file changed

-1

lines changed

src/bin/pgbench
- pgbench.c

1 file changed

-1

lines changed

`‎src/bin/pgbench/pgbench.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -4908,7 +4908,7 @@ initPopulateTable(PGconn con, const char table, int64 base,`
`4908`	`4908`	`initRowMethodinit_row)`
`4909`	`4909`	`{`
`4910`	`4910`	`intn;`
`4911`		`-intk;`
	`4911`	`+int64k;`
`4912`	`4912`	`intchars=0;`
`4913`	`4913`	`PGresult*res;`
`4914`	`4914`	`PQExpBufferDatasql;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit64e77b4

File tree

1 file changed

1 file changed

`‎src/bin/pgbench/pgbench.c`

0 commit comments