NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit64ae420

committed

Repair test for vacuum reltuples fix.

Concurrent auto-analyze could be holding a snapshot, affecting theremoval of deleted row versions. Remove the deletion to avoid thishappening. Per buildfarm.In passing, make the test independent of assumptions of physical roworder, just out of sheer paranoia.

1 parent88e66d1 commit64ae420Copy full SHA for 64ae420

File tree

2 files changed

+10

-10

lines changed

src/test/isolation
- expected
  - vacuum-reltuples.out
- specs
  - vacuum-reltuples.spec

2 files changed

+10

-10

lines changed

`‎src/test/isolation/expected/vacuum-reltuples.out`

Lines changed: 5 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -3,7 +3,6 @@ Parsed test spec with 2 sessions`
`3`	`3`	`starting permutation: modify vac stats`
`4`	`4`	`step modify:`
`5`	`5`	`insert into smalltbl select max(id)+1 from smalltbl;`
`6`		`- delete from smalltbl where id in (select min(id) from smalltbl);`
`7`	`6`
`8`	`7`	`step vac:`
`9`	`8`	`vacuum smalltbl;`
`@@ -14,23 +13,22 @@ step stats:`
`14`	`13`
`15`	`14`	`relpages reltuples`
`16`	`15`
`17`		`-120`
	`16`	`+121`
`18`	`17`
`19`	`18`	`starting permutation: modify open fetch1 vac close stats`
`20`	`19`	`step modify:`
`21`	`20`	`insert into smalltbl select max(id)+1 from smalltbl;`
`22`		`- delete from smalltbl where id in (select min(id) from smalltbl);`
`23`	`21`
`24`	`22`	`step open:`
`25`	`23`	`begin;`
`26`		`- declare c1 cursor for select* from smalltbl;`
	`24`	`+ declare c1 cursor for select1 as dummy from smalltbl;`
`27`	`25`
`28`	`26`	`step fetch1:`
`29`	`27`	`fetch next from c1;`
`30`	`28`
`31`		`-id`
	`29`	`+dummy`
`32`	`30`
`33`		`-2`
	`31`	`+1`
`34`	`32`	`step vac:`
`35`	`33`	`vacuum smalltbl;`
`36`	`34`
`@@ -48,7 +46,6 @@ relpages reltuples`
`48`	`46`	`starting permutation: modify vac stats`
`49`	`47`	`step modify:`
`50`	`48`	`insert into smalltbl select max(id)+1 from smalltbl;`
`51`		`- delete from smalltbl where id in (select min(id) from smalltbl);`
`52`	`49`
`53`	`50`	`step vac:`
`54`	`51`	`vacuum smalltbl;`
`@@ -59,4 +56,4 @@ step stats:`
`59`	`56`
`60`	`57`	`relpages reltuples`
`61`	`58`
`62`		`-120`
	`59`	`+121`

`‎src/test/isolation/specs/vacuum-reltuples.spec`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,10 @@`
`1`	`1`	`# Test for vacuum's handling of reltuples when pages are skipped due`
`2`	`2`	`# to page pins. We absolutely need to avoid setting reltuples=0 in`
`3`	`3`	`# such cases, since that interferes badly with planning.`
	`4`	`+#`
	`5`	`+# Expected result in second permutation is 20 tuples rather than 21 as`
	`6`	`+# for the others, because vacuum should leave the previous result`
	`7`	`+# (from before the insert) in place.`
`4`	`8`
`5`	`9`	`setup {`
`6`	`10`	`createtablesmalltbl`
`@@ -18,7 +22,7 @@ teardown {`
`18`	`22`	`session"worker"`
`19`	`23`	`step"open" {`
`20`	`24`	`begin;`
`21`		`-declarec1cursorforselect*fromsmalltbl;`
	`25`	`+declarec1cursorforselect1asdummyfromsmalltbl;`
`22`	`26`	`}`
`23`	`27`	`step"fetch1" {`
`24`	`28`	`fetchnextfromc1;`
`@@ -37,7 +41,6 @@ step "vac" {`
`37`	`41`	`}`
`38`	`42`	`step"modify" {`
`39`	`43`	`insertintosmalltblselectmax(id)+1fromsmalltbl;`
`40`		`-deletefromsmalltblwhereidin (selectmin(id)fromsmalltbl);`
`41`	`44`	`}`
`42`	`45`
`43`	`46`	`permutation"modify""vac""stats"`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit64ae420

File tree

2 files changed

2 files changed

`‎src/test/isolation/expected/vacuum-reltuples.out`

`‎src/test/isolation/specs/vacuum-reltuples.spec`

0 commit comments