Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit63fc3b1

Browse files
committed
Fix error handling of vacuumdb when running out of fds
When trying to use a high number of jobs, vacuumdb has only checked fora maximum number of jobs used, causing confusing failures when runningout of file descriptors when the jobs open connections to Postgres.This commit changes the error handling so as we do not check anymore fora maximum number of allowed jobs when parsing the option value withFD_SETSIZE, but check instead if a file descriptor is within thesupported range when opening the connections for the jobs so as this isdetected at the earliest time possible.Also, improve the error message to give a hint about the number of jobsrecommended, using a wording given by the reviewers of the patch.Reported-by: Andres FreundAuthor: Michael PaquierReviewed-by: Andres Freund, Álvaro Herrera, Tom LaneDiscussion:https://postgr.es/m/20190818001858.ho3ev4z57fqhs7a5@alap3.anarazel.deBackpatch-through: 9.5
1 parent3633825 commit63fc3b1

File tree

1 file changed

+12
-6
lines changed

1 file changed

+12
-6
lines changed

‎src/bin/scripts/vacuumdb.c‎

Lines changed: 12 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -207,12 +207,6 @@ main(int argc, char *argv[])
207207
pg_log_error("number of parallel jobs must be at least 1");
208208
exit(1);
209209
}
210-
if (concurrentCons>FD_SETSIZE-1)
211-
{
212-
pg_log_error("too many parallel jobs requested (maximum: %d)",
213-
FD_SETSIZE-1);
214-
exit(1);
215-
}
216210
break;
217211
case2:
218212
maintenance_db=pg_strdup(optarg);
@@ -633,6 +627,18 @@ vacuum_one_database(const char *dbname, vacuumingOptions *vacopts,
633627
{
634628
conn=connectDatabase(dbname,host,port,username,prompt_password,
635629
progname,echo, false, true);
630+
631+
/*
632+
* Fail and exit immediately if trying to use a socket in an
633+
* unsupported range. POSIX requires open(2) to use the lowest
634+
* unused file descriptor and the hint given relies on that.
635+
*/
636+
if (PQsocket(conn) >=FD_SETSIZE)
637+
{
638+
pg_log_fatal("too many jobs for this platform -- try %d",i);
639+
exit(1);
640+
}
641+
636642
init_slot(slots+i,conn);
637643
}
638644
}

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp