Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

Commit63d3e11

Browse files
committed
Allow SSL TAP tests to run on Windows
Windows does not enforce key file permissions checks in libpq, and psqlcan produce CRLF line endings on Windows.Backpatch to Release 12 (CRLF) and Release 11 (permissions check)
1 parentbba1bae commit63d3e11

File tree

1 file changed

+14
-9
lines changed

1 file changed

+14
-9
lines changed

‎src/test/ssl/t/001_ssltests.pl

Lines changed: 14 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -324,8 +324,8 @@
324324
"$common_connstr sslrootcert=invalid",'-c',
325325
"SELECT * FROM pg_stat_ssl WHERE pid = pg_backend_pid()"
326326
],
327-
qr{^pid,ssl,version,cipher,bits,compression,client_dn,client_serial,issuer_dn\n
328-
^\d+,t,TLSv[\d.]+,[\w-]+,\d+,f,_null_,_null_,_null_$}mx,
327+
qr{^pid,ssl,version,cipher,bits,compression,client_dn,client_serial,issuer_dn\r?\n
328+
^\d+,t,TLSv[\d.]+,[\w-]+,\d+,f,_null_,_null_,_null_\r?$}mx,
329329
'pg_stat_ssl view without client certificate');
330330

331331
### Server-side tests.
@@ -365,16 +365,21 @@
365365
'-c',
366366
"SELECT * FROM pg_stat_ssl WHERE pid = pg_backend_pid()"
367367
],
368-
qr{^pid,ssl,version,cipher,bits,compression,client_dn,client_serial,issuer_dn\n
369-
^\d+,t,TLSv[\d.]+,[\w-]+,\d+,f,/CN=ssltestuser,1,\Q/CN=Test CA for PostgreSQL SSL regression test client certs\E$}mx,
368+
qr{^pid,ssl,version,cipher,bits,compression,client_dn,client_serial,issuer_dn\r?\n
369+
^\d+,t,TLSv[\d.]+,[\w-]+,\d+,f,/CN=ssltestuser,1,\Q/CN=Test CA for PostgreSQL SSL regression test client certs\E\r?$}mx,
370370
'pg_stat_ssl with client certificate');
371371

372372
# client key with wrong permissions
373-
test_connect_fails(
374-
$common_connstr,
375-
"user=ssltestuser sslcert=ssl/client.crt sslkey=ssl/client_wrongperms_tmp.key",
376-
qr!\Qprivate key file "ssl/client_wrongperms_tmp.key" has group or world access\E!,
377-
"certificate authorization fails because of file permissions");
373+
SKIP:
374+
{
375+
skip"Permissions check not enforced on Windows", 2if ($windows_os);
376+
377+
test_connect_fails(
378+
$common_connstr,
379+
"user=ssltestuser sslcert=ssl/client.crt sslkey=ssl/client_wrongperms_tmp.key",
380+
qr!\Qprivate key file "ssl/client_wrongperms_tmp.key" has group or world access\E!,
381+
"certificate authorization fails because of file permissions");
382+
}
378383

379384
# client cert belonging to another user
380385
test_connect_fails(

0 commit comments

Comments
 (0)

[8]ページ先頭

©2009-2025 Movatter.jp