NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit63932a6

committed

Fix wal_writer_flush_after initializer value.

Commita73952b (new in 16) required default values in guc_table.cand C variable initializers to match. This one only matched whenXLOG_BLCKSZ == 8kB. Fix by using the same expression in both placeswith a new DEFAULT_XXX macro, as done for other GUCs.Reviewed-by: Andres Freund <andres@anarazel.de>Discussion:https://postgr.es/m/CA+hUKGLNmLV=VrT==5MqnbARgx2ifRSFtdd8ofdfrdSLL3yv5A@mail.gmail.com

1 parent319bae9 commit63932a6Copy full SHA for 63932a6

File tree

3 files changed

-2

lines changed

src
- backend
  - postmaster
    - walwriter.c
  - utils/misc
    - guc_tables.c
- include/postmaster
  - walwriter.h

3 files changed

-2

lines changed

`‎src/backend/postmaster/walwriter.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@`
`68`	`68`	`* GUC parameters`
`69`	`69`	`*/`
`70`	`70`	`intWalWriterDelay=200;`
`71`		`-intWalWriterFlushAfter=128;`
	`71`	`+intWalWriterFlushAfter=DEFAULT_WAL_WRITER_FLUSH_AFTER;`
`72`	`72`
`73`	`73`	`/*`
`74`	`74`	`* Number of do-nothing loops before lengthening the delay time, and the`

`‎src/backend/utils/misc/guc_tables.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2780,7 +2780,7 @@ struct config_int ConfigureNamesInt[] =`
`2780`	`2780`	`GUC_UNIT_XBLOCKS`
`2781`	`2781`	`},`
`2782`	`2782`	`&WalWriterFlushAfter,`
`2783`		`-(1024*1024) /XLOG_BLCKSZ,0,INT_MAX,`
	`2783`	`+DEFAULT_WAL_WRITER_FLUSH_AFTER,0,INT_MAX,`
`2784`	`2784`	`NULL,NULL,NULL`
`2785`	`2785`	`},`
`2786`	`2786`

`‎src/include/postmaster/walwriter.h`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,8 @@`
`12`	`12`	`#ifndef_WALWRITER_H`
`13`	`13`	`#define_WALWRITER_H`
`14`	`14`
	`15`	`+#defineDEFAULT_WAL_WRITER_FLUSH_AFTER ((1024 * 1024) / XLOG_BLCKSZ)`
	`16`	`+`
`15`	`17`	`/* GUC options */`
`16`	`18`	`externPGDLLIMPORTintWalWriterDelay;`
`17`	`19`	`externPGDLLIMPORTintWalWriterFlushAfter;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit63932a6

File tree

3 files changed

3 files changed

`‎src/backend/postmaster/walwriter.c`

`‎src/backend/utils/misc/guc_tables.c`

`‎src/include/postmaster/walwriter.h`

0 commit comments