NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit62e1e28

committed

Fix pgindent --show-diff option.

At least on my machine, the initial coding of this didn't actuallywork, because interpolation of "$post_fh->filename" doesn't actas intended.I threw in some double quotes too, just in case anybody triesto run this in a path containing spaces.

1 parent3cece34 commit62e1e28Copy full SHA for 62e1e28

File tree

1 file changed

-1

lines changed

src/tools/pgindent
- pgindent

1 file changed

-1

lines changed

`‎src/tools/pgindent/pgindent`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -299,12 +299,13 @@ sub show_diff`
`299`	`299`	`my$source_filename =shift;`
`300`	`300`
`301`	`301`	`my$post_fh = new File::Temp(TEMPLATE=>"pgdiffXXXXX");`
	`302`	`+my$post_fh_filename =$post_fh->filename;`
`302`	`303`
`303`	`304`	`print$post_fh$indented;`
`304`	`305`
`305`	`306`	`$post_fh->close();`
`306`	`307`
`307`		-my$diff =`diff -upd$source_filename$post_fh->filename 2>&1`;
	`308`	+my$diff =`diff -upd"$source_filename" "$post_fh_filename" 2>&1`;
`308`	`309`	`return$diff;`
`309`	`310`	`}`
`310`	`311`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit62e1e28

File tree

1 file changed

1 file changed

`‎src/tools/pgindent/pgindent`

0 commit comments