NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit628bc9d

committed

Rename the role in stats_ext to have regress_ prefix

Commit5be8ce8 added a new role to the stats_ext regression suite,but the role name did not start with regress_ causing failures whenrunning with ENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS. Fixed byrenaming the role to start with the expected regress_ prefix.Backpatch-through: 10, same as the new regression testDiscussion:https://postgr.es/m/1F238937-7CC2-4703-A1B1-6DC225B8978A%40enterprisedb.com

1 parent5be8ce8 commit628bc9dCopy full SHA for 628bc9d

File tree

2 files changed

-6

lines changed

src/test/regress
- expected
  - stats_ext.out
- sql
  - stats_ext.sql

2 files changed

-6

lines changed

`‎src/test/regress/expected/stats_ext.out`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -68,16 +68,16 @@ DROP TABLE ext_stats_test;`
`68`	`68`	`CREATE TABLE ab1 (a INTEGER, b INTEGER, c INTEGER);`
`69`	`69`	`CREATE STATISTICS IF NOT EXISTS ab1_a_b_stats ON a, b FROM ab1;`
`70`	`70`	`COMMENT ON STATISTICS ab1_a_b_stats IS 'new comment';`
`71`		`-CREATE ROLEtemp_role;`
`72`		`-SET SESSION AUTHORIZATIONtemp_role;`
	`71`	`+CREATE ROLEregress_stats_ext;`
	`72`	`+SET SESSION AUTHORIZATIONregress_stats_ext;`
`73`	`73`	`COMMENT ON STATISTICS ab1_a_b_stats IS 'changed comment';`
`74`	`74`	`ERROR: must be owner of statistics object ab1_a_b_stats`
`75`	`75`	`DROP STATISTICS ab1_a_b_stats;`
`76`	`76`	`ERROR: must be owner of statistics object ab1_a_b_stats`
`77`	`77`	`ALTER STATISTICS ab1_a_b_stats RENAME TO ab1_a_b_stats_new;`
`78`	`78`	`ERROR: must be owner of statistics object ab1_a_b_stats`
`79`	`79`	`RESET SESSION AUTHORIZATION;`
`80`		`-DROP ROLEtemp_role;`
	`80`	`+DROP ROLEregress_stats_ext;`
`81`	`81`	`CREATE STATISTICS IF NOT EXISTS ab1_a_b_stats ON a, b FROM ab1;`
`82`	`82`	`NOTICE: statistics object "ab1_a_b_stats" already exists, skipping`
`83`	`83`	`DROP STATISTICS ab1_a_b_stats;`

`‎src/test/regress/sql/stats_ext.sql`

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -49,13 +49,13 @@ DROP TABLE ext_stats_test;`
`49`	`49`	`CREATETABLEab1 (aINTEGER, bINTEGER, cINTEGER);`
`50`	`50`	`CREATE STATISTICS IF NOT EXISTS ab1_a_b_statsON a, bFROM ab1;`
`51`	`51`	`COMMENTON STATISTICS ab1_a_b_stats IS'new comment';`
`52`		`-CREATE ROLEtemp_role;`
`53`		`-SET SESSION AUTHORIZATIONtemp_role;`
	`52`	`+CREATE ROLEregress_stats_ext;`
	`53`	`+SET SESSION AUTHORIZATIONregress_stats_ext;`
`54`	`54`	`COMMENTON STATISTICS ab1_a_b_stats IS'changed comment';`
`55`	`55`	`DROP STATISTICS ab1_a_b_stats;`
`56`	`56`	`ALTER STATISTICS ab1_a_b_stats RENAME TO ab1_a_b_stats_new;`
`57`	`57`	`RESET SESSION AUTHORIZATION;`
`58`		`-DROP ROLEtemp_role;`
	`58`	`+DROP ROLEregress_stats_ext;`
`59`	`59`
`60`	`60`	`CREATE STATISTICS IF NOT EXISTS ab1_a_b_statsON a, bFROM ab1;`
`61`	`61`	`DROP STATISTICS ab1_a_b_stats;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit628bc9d

File tree

2 files changed

2 files changed

`‎src/test/regress/expected/stats_ext.out`

`‎src/test/regress/sql/stats_ext.sql`

0 commit comments