Commit6244c2d

committed

Fix stddev_pop(numeric) and var_pop(numeric), which were incorrectly producing

the same outputs as stddev_samp() and var_samp() respectively.

1 parent9e09e3b commit6244c2dCopy full SHA for 6244c2d

File tree

-4

lines changed

src
- backend/utils/adt
  - numeric.c
- test/regress/expected
  - aggregates.out

-4

lines changed

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -14,7 +14,7 @@`
`14`	`14`	`* Copyright (c) 1998-2007, PostgreSQL Global Development Group`
`15`	`15`	`*`
`16`	`16`	`* IDENTIFICATION`
`17`		`- * $PostgreSQL: pgsql/src/backend/utils/adt/numeric.c,v 1.105 2007/06/15 20:56:50 tgl Exp $`
	`17`	`+ * $PostgreSQL: pgsql/src/backend/utils/adt/numeric.c,v 1.106 2007/07/09 16:13:57 tgl Exp $`
`18`	`18`	`*`
`19`	`19`	`*-------------------------------------------------------------------------`
`20`	`20`	`*/`
`@@ -2435,7 +2435,10 @@ numeric_stddev_internal(ArrayType *transarray,`
`2435`	`2435`	`}`
`2436`	`2436`	`else`
`2437`	`2437`	`{`
`2438`		`-mul_var(&vN,&vNminus1,&vNminus1,0);/* N * (N - 1) */`
	`2438`	`+if (sample)`
	`2439`	`+mul_var(&vN,&vNminus1,&vNminus1,0);/* N * (N - 1) */`
	`2440`	`+else`
	`2441`	`+mul_var(&vN,&vN,&vNminus1,0);/* N * N */`
`2439`	`2442`	`rscale=select_div_scale(&vsumX2,&vNminus1);`
`2440`	`2443`	`div_var(&vsumX2,&vNminus1,&vsumX,rscale, true);/* variance */`
`2441`	`2444`	`if (!variance)`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -102,7 +102,7 @@ SELECT var_samp(b) FROM aggtest;`
`102`	`102`	`SELECT stddev_pop(b::numeric) FROM aggtest;`
`103`	`103`	`stddev_pop`
`104`	`104`	`------------------`
`105`		`-151.389361431288`
	`105`	`+131.107032862199`
`106`	`106`	`(1 row)`
`107`	`107`
`108`	`108`	`SELECT stddev_samp(b::numeric) FROM aggtest;`
`@@ -114,7 +114,7 @@ SELECT stddev_samp(b::numeric) FROM aggtest;`
`114`	`114`	`SELECT var_pop(b::numeric) FROM aggtest;`
`115`	`115`	`var_pop`
`116`	`116`	`--------------------`
`117`		`-22918.738754573025`
	`117`	`+17189.054065929769`
`118`	`118`	`(1 row)`
`119`	`119`
`120`	`120`	`SELECT var_samp(b::numeric) FROM aggtest;`

Comments

(0)