Commit620c2c3

Thomas G. Lockhart

committed

Update the random test so it should succeed most of the time.

Instead of directly showing the random results, test the results for the expected behavior (range and randomness).

1 parenta8bcb8b commit620c2c3Copy full SHA for 620c2c3

File tree

+33

-13

lines changed

+33

-13

lines changed

Lines changed: 15 additions & 10 deletions

Original file line number	Diff line number	Diff line change
`@@ -4,15 +4,20 @@ count`
`4`	`4`	`1000`
`5`	`5`	`(1 row)`
`6`	`6`
`7`		`-QUERY: SELECT count(*) FROM onek where oidrand(onek.oid, 10);`
`8`		`-count`
`9`		`------`
`10`		`- 92`
`11`		`-(1 row)`
	`7`	`+QUERY: SELECT count(*) AS random INTO RANDOM_TBL`
	`8`	`+ FROM onek WHERE oidrand(onek.oid, 10);`
	`9`	`+QUERY: INSERT INTO RANDOM_TBL (random)`
	`10`	`+ SELECT count(*)`
	`11`	`+ FROM onek WHERE oidrand(onek.oid, 10);`
	`12`	`+QUERY: SELECT random, count(random) FROM RANDOM_TBL`
	`13`	`+ GROUP BY random HAVING count(random) > 1;`
	`14`	`+random\|count`
	`15`	`+------+-----`
	`16`	`+(0 rows)`
`12`	`17`
`13`		`-QUERY: SELECTcount(*) FROMonek where oidrand(onek.oid, 10);`
`14`		`-count`
`15`		`------`
`16`		`- 98`
`17`		`-(1 row)`
	`18`	`+QUERY: SELECTrandom FROMRANDOM_TBL`
	`19`	`+ WHERE random NOT BETWEEN 80 AND 120;`
	`20`	`+random`
	`21`	`+------`
	`22`	`+(0 rows)`
`18`	`23`

Lines changed: 2 additions & 1 deletion

Lines changed: 16 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5,8 +5,22 @@`
`5`	`5`	`SELECTcount(*)FROM onek;`
`6`	`6`
`7`	`7`	`-- select roughly 1/10 of the tuples`
`8`		`-SELECTcount(*)FROM onekwhere oidrand(onek.oid,10);`
	`8`	`+-- Assume that the "onek" table has 1000 tuples`
	`9`	`+-- and try to bracket the correct number so we`
	`10`	`+-- have a regression test which can pass/fail`
	`11`	`+-- - thomas 1998-08-17`
	`12`	`+SELECTcount(*)AS random INTO RANDOM_TBL`
	`13`	`+FROM onekWHERE oidrand(onek.oid,10);`
`9`	`14`
`10`	`15`	`-- select again, the count should be different`
`11`		`-SELECTcount(*)FROM onekwhere oidrand(onek.oid,10);`
	`16`	`+INSERT INTO RANDOM_TBL (random)`
	`17`	`+SELECTcount(*)`
	`18`	`+FROM onekWHERE oidrand(onek.oid,10);`
	`19`	`+`
	`20`	`+-- now test the results for randomness in the correct range`
	`21`	`+SELECT random,count(random)FROM RANDOM_TBL`
	`22`	`+GROUP BY randomHAVINGcount(random)>1;`
	`23`	`+`
	`24`	`+SELECT randomFROM RANDOM_TBL`
	`25`	`+WHERE random NOT BETWEEN80AND120;`
`12`	`26`

Comments

(0)