Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit6207f08

Browse files
Harmonize function parameter names for Postgres 17.
Make sure that function declarations use names that exactly match thecorresponding names from function definitions in a few places. Theseinconsistencies were all introduced during Postgres 17 development.pg_bsd_indent still has a couple of similar inconsistencies, which I(pgeoghegan) have left untouched for now.This commit was written with help from clang-tidy, by mechanicallyapplying the same rules as similar clean-up commits (the earliest suchcommit was commit035ce1f).
1 parenta0fe90e commit6207f08

File tree

27 files changed

+65
-63
lines changed

27 files changed

+65
-63
lines changed

‎src/backend/access/brin/brin.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -229,11 +229,11 @@ static void _brin_begin_parallel(BrinBuildState *buildstate, Relation heap, Rela
229229
boolisconcurrent,intrequest);
230230
staticvoid_brin_end_parallel(BrinLeader*brinleader,BrinBuildState*state);
231231
staticSize_brin_parallel_estimate_shared(Relationheap,Snapshotsnapshot);
232-
staticdouble_brin_parallel_heapscan(BrinBuildState*buildstate);
233-
staticdouble_brin_parallel_merge(BrinBuildState*buildstate);
232+
staticdouble_brin_parallel_heapscan(BrinBuildState*state);
233+
staticdouble_brin_parallel_merge(BrinBuildState*state);
234234
staticvoid_brin_leader_participate_as_worker(BrinBuildState*buildstate,
235235
Relationheap,Relationindex);
236-
staticvoid_brin_parallel_scan_and_build(BrinBuildState*buildstate,
236+
staticvoid_brin_parallel_scan_and_build(BrinBuildState*state,
237237
BrinShared*brinshared,
238238
Sharedsort*sharedsort,
239239
Relationheap,Relationindex,

‎src/backend/access/heap/vacuumlazy.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -246,7 +246,7 @@ static void lazy_vacuum(LVRelState *vacrel);
246246
staticboollazy_vacuum_all_indexes(LVRelState*vacrel);
247247
staticvoidlazy_vacuum_heap_rel(LVRelState*vacrel);
248248
staticvoidlazy_vacuum_heap_page(LVRelState*vacrel,BlockNumberblkno,
249-
Bufferbuffer,OffsetNumber*offsets,
249+
Bufferbuffer,OffsetNumber*deadoffsets,
250250
intnum_offsets,Buffervmbuffer);
251251
staticboollazy_check_wraparound_failsafe(LVRelState*vacrel);
252252
staticvoidlazy_cleanup_all_indexes(LVRelState*vacrel);

‎src/backend/backup/basebackup_incremental.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -141,7 +141,7 @@ static void manifest_process_wal_range(JsonManifestParseContext *context,
141141
TimeLineIDtli,
142142
XLogRecPtrstart_lsn,
143143
XLogRecPtrend_lsn);
144-
staticvoidmanifest_report_error(JsonManifestParseContext*ib,
144+
staticvoidmanifest_report_error(JsonManifestParseContext*context,
145145
constchar*fmt,...)
146146
pg_attribute_printf(2,3)pg_attribute_noreturn();
147147
staticintcompare_block_numbers(constvoid*a,constvoid*b);

‎src/backend/backup/basebackup_zstd.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@ typedef struct bbsink_zstd
3434

3535
staticvoidbbsink_zstd_begin_backup(bbsink*sink);
3636
staticvoidbbsink_zstd_begin_archive(bbsink*sink,constchar*archive_name);
37-
staticvoidbbsink_zstd_archive_contents(bbsink*sink,size_tavail_in);
37+
staticvoidbbsink_zstd_archive_contents(bbsink*sink,size_tlen);
3838
staticvoidbbsink_zstd_manifest_contents(bbsink*sink,size_tlen);
3939
staticvoidbbsink_zstd_end_archive(bbsink*sink);
4040
staticvoidbbsink_zstd_cleanup(bbsink*sink);

‎src/backend/commands/tablecmds.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ static ObjectAddress ATExecClusterOn(Relation rel, const char *indexName,
589589
LOCKMODE lockmode);
590590
static void ATExecDropCluster(Relation rel, LOCKMODE lockmode);
591591
static void ATPrepSetAccessMethod(AlteredTableInfo *tab, Relation rel, const char *amname);
592-
static void ATExecSetAccessMethodNoStorage(Relation rel, OidnewAccessMethod);
592+
static void ATExecSetAccessMethodNoStorage(Relation rel, OidnewAccessMethodId);
593593
static bool ATPrepChangePersistence(Relation rel, bool toLogged);
594594
static void ATPrepSetTableSpace(AlteredTableInfo *tab, Relation rel,
595595
const char *tablespacename, LOCKMODE lockmode);

‎src/backend/optimizer/path/joinrels.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ static void try_partitionwise_join(PlannerInfo *root, RelOptInfo *rel1,
4545
staticSpecialJoinInfo*build_child_join_sjinfo(PlannerInfo*root,
4646
SpecialJoinInfo*parent_sjinfo,
4747
Relidsleft_relids,Relidsright_relids);
48-
staticvoidfree_child_join_sjinfo(SpecialJoinInfo*child_sjinfo);
48+
staticvoidfree_child_join_sjinfo(SpecialJoinInfo*sjinfo);
4949
staticvoidcompute_partition_bounds(PlannerInfo*root,RelOptInfo*rel1,
5050
RelOptInfo*rel2,RelOptInfo*joinrel,
5151
SpecialJoinInfo*parent_sjinfo,

‎src/backend/parser/parse_expr.c‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -88,11 +88,11 @@ static Node *transformJsonArrayQueryConstructor(ParseState *pstate,
8888
staticNode*transformJsonObjectAgg(ParseState*pstate,JsonObjectAgg*agg);
8989
staticNode*transformJsonArrayAgg(ParseState*pstate,JsonArrayAgg*agg);
9090
staticNode*transformJsonIsPredicate(ParseState*pstate,JsonIsPredicate*pred);
91-
staticNode*transformJsonParseExpr(ParseState*pstate,JsonParseExpr*expr);
92-
staticNode*transformJsonScalarExpr(ParseState*pstate,JsonScalarExpr*expr);
91+
staticNode*transformJsonParseExpr(ParseState*pstate,JsonParseExpr*jsexpr);
92+
staticNode*transformJsonScalarExpr(ParseState*pstate,JsonScalarExpr*jsexpr);
9393
staticNode*transformJsonSerializeExpr(ParseState*pstate,
9494
JsonSerializeExpr*expr);
95-
staticNode*transformJsonFuncExpr(ParseState*pstate,JsonFuncExpr*p);
95+
staticNode*transformJsonFuncExpr(ParseState*pstate,JsonFuncExpr*func);
9696
staticvoidtransformJsonPassingArgs(ParseState*pstate,constchar*constructName,
9797
JsonFormatTypeformat,List*args,
9898
List**passing_values,List**passing_names);

‎src/backend/replication/libpqwalreceiver/libpqwalreceiver.c‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ static void libpqrcv_get_senderinfo(WalReceiverConn *conn,
5959
char**sender_host,int*sender_port);
6060
staticchar*libpqrcv_identify_system(WalReceiverConn*conn,
6161
TimeLineID*primary_tli);
62-
staticchar*libpqrcv_get_dbname_from_conninfo(constchar*conninfo);
62+
staticchar*libpqrcv_get_dbname_from_conninfo(constchar*connInfo);
6363
staticintlibpqrcv_server_version(WalReceiverConn*conn);
6464
staticvoidlibpqrcv_readtimelinehistoryfile(WalReceiverConn*conn,
6565
TimeLineIDtli,char**filename,

‎src/backend/utils/adt/jsonpath_exec.c‎

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -318,7 +318,7 @@ static void getJsonPathVariable(JsonPathExecContext *cxt,
318318
JsonPathItem*variable,JsonbValue*value);
319319
staticintcountVariablesFromJsonb(void*varsJsonb);
320320
staticJsonbValue*getJsonPathVariableFromJsonb(void*varsJsonb,char*varName,
321-
intvarNameLen,
321+
intvarNameLength,
322322
JsonbValue*baseObject,
323323
int*baseObjectId);
324324
staticintJsonbArraySize(JsonbValue*jb);
@@ -342,7 +342,6 @@ static void JsonValueListInitIterator(const JsonValueList *jvl,
342342
JsonValueListIterator*it);
343343
staticJsonbValue*JsonValueListNext(constJsonValueList*jvl,
344344
JsonValueListIterator*it);
345-
staticintJsonbType(JsonbValue*jb);
346345
staticJsonbValue*JsonbInitBinary(JsonbValue*jbv,Jsonb*jb);
347346
staticintJsonbType(JsonbValue*jb);
348347
staticJsonbValue*getScalar(JsonbValue*scalar,enumjbvTypetype);
@@ -359,7 +358,7 @@ static JsonTablePlanState *JsonTableInitPlan(JsonTableExecContext *cxt,
359358
List*args,
360359
MemoryContextmcxt);
361360
staticvoidJsonTableSetDocument(TableFuncScanState*state,Datumvalue);
362-
staticvoidJsonTableResetRowPattern(JsonTablePlanState*plan,Datumitem);
361+
staticvoidJsonTableResetRowPattern(JsonTablePlanState*planstate,Datumitem);
363362
staticboolJsonTableFetchRow(TableFuncScanState*state);
364363
staticDatumJsonTableGetValue(TableFuncScanState*state,intcolnum,
365364
Oidtypid,int32typmod,bool*isnull);

‎src/bin/pg_combinebackup/copy_file.c‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,10 +25,10 @@
2525
staticvoidcopy_file_blocks(constchar*src,constchar*dst,
2626
pg_checksum_context*checksum_ctx);
2727

28-
staticvoidcopy_file_clone(constchar*src,constchar*dst,
28+
staticvoidcopy_file_clone(constchar*src,constchar*dest,
2929
pg_checksum_context*checksum_ctx);
3030

31-
staticvoidcopy_file_by_range(constchar*src,constchar*dst,
31+
staticvoidcopy_file_by_range(constchar*src,constchar*dest,
3232
pg_checksum_context*checksum_ctx);
3333

3434
#ifdefWIN32

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp