NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit61fd218

committed

Fix minor thinko in pathification code.

I passed the wrong "root" struct to create_pathtarget in build_minmax_path.Since the subroot is a clone of the outer root, this would not cause anyserious problems, but it would waste some cycles becauseset_pathtarget_cost_width would not have access to Var width estimatesset up while running query_planner on the subroot.

1 parente66197f commit61fd218Copy full SHA for 61fd218

File tree

1 file changed

-1

lines changed

src/backend/optimizer/plan
- planagg.c

1 file changed

-1

lines changed

`‎src/backend/optimizer/plan/planagg.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -465,7 +465,7 @@ build_minmax_path(PlannerInfo root, MinMaxAggInfo mminfo,`
`465`	`465`	`* cheapest path.)`
`466`	`466`	`*/`
`467`	`467`	`sorted_path=apply_projection_to_path(subroot,final_rel,sorted_path,`
`468`		`-create_pathtarget(root,tlist));`
	`468`	`+create_pathtarget(subroot,tlist));`
`469`	`469`
`470`	`470`	`/*`
`471`	`471`	`* Determine cost to get just the first row of the presorted path.`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit61fd218

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/plan/planagg.c`

0 commit comments