Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit61f08c0

Browse files
committed
Fix StoreCatalogInheritance1 to use 32bit inhseqno
For no apparent reason, this function was using a 16bit-wide inhseqnovalue, rather than the correct 32 bit width which is what is stored inthe pg_inherits catalog. This becomes evident if you try to create atable with more than 65535 parents, because this error appears:ERROR: duplicate key value violates unique constraint «pg_inherits_relid_seqno_index»DETAIL: Key (inhrelid, inhseqno)=(329371, 0) already exists.Needless to say, having so many parents is an uncommon situations, whichexplains why this error has never been reported despite being havingbeen introduced with the Postgres95 1.01 sources in commitd31084e:https://git.postgresql.org/gitweb/?p=postgresql.git;a=blob;f=src/backend/commands/creatinh.c;hb=d31084e9d111#l349Backpatch all the way back.David Rowley noticed this while reviewing a patch of mine.Discussion:https://postgr.es/m/CAKJS1f8Dn7swSEhOWwzZzssW7747YB=2Hi+T7uGud40dur69-g@mail.gmail.com
1 parent5dcbdcb commit61f08c0

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

‎src/backend/commands/tablecmds.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -301,7 +301,7 @@ static void MergeConstraintsIntoExisting(Relation child_rel, Relation parent_rel
301301
staticvoidStoreCatalogInheritance(OidrelationId,List*supers,
302302
boolchild_is_partition);
303303
staticvoidStoreCatalogInheritance1(OidrelationId,OidparentOid,
304-
int16seqNumber,RelationinhRelation,
304+
int32seqNumber,RelationinhRelation,
305305
boolchild_is_partition);
306306
staticintfindAttrByName(constchar*attributeName,List*schema);
307307
staticvoidAlterIndexNamespaces(RelationclassRel,Relationrel,
@@ -2300,7 +2300,7 @@ StoreCatalogInheritance(Oid relationId, List *supers,
23002300
boolchild_is_partition)
23012301
{
23022302
Relationrelation;
2303-
int16seqNumber;
2303+
int32seqNumber;
23042304
ListCell*entry;
23052305

23062306
/*
@@ -2341,7 +2341,7 @@ StoreCatalogInheritance(Oid relationId, List *supers,
23412341
*/
23422342
staticvoid
23432343
StoreCatalogInheritance1(OidrelationId,OidparentOid,
2344-
int16seqNumber,RelationinhRelation,
2344+
int32seqNumber,RelationinhRelation,
23452345
boolchild_is_partition)
23462346
{
23472347
TupleDescdesc=RelationGetDescr(inhRelation);
@@ -2356,7 +2356,7 @@ StoreCatalogInheritance1(Oid relationId, Oid parentOid,
23562356
*/
23572357
values[Anum_pg_inherits_inhrelid-1]=ObjectIdGetDatum(relationId);
23582358
values[Anum_pg_inherits_inhparent-1]=ObjectIdGetDatum(parentOid);
2359-
values[Anum_pg_inherits_inhseqno-1]=Int16GetDatum(seqNumber);
2359+
values[Anum_pg_inherits_inhseqno-1]=Int32GetDatum(seqNumber);
23602360

23612361
memset(nulls,0,sizeof(nulls));
23622362

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp