NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit6197d7b

committed

Report tuple address in data-corruption error message

Most data-corruption reports mention the location of the problem, butthis one failed to. Add it.Backpatch all the way back. In 12 and older, also assign theERRCODE_DATA_CORRUPTED error code as was done in commitfd6ec93 for13 and later.Discussion:https://postgr.es/m/202108191637.oqyzrdtnheir@alvherre.pgsql

1 parent8ba3bad commit6197d7bCopy full SHA for 6197d7b

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam_handler.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam_handler.c`

Lines changed: 5 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -422,7 +422,11 @@ heapam_tuple_lock(Relation relation, ItemPointer tid, Snapshot snapshot,`
`422`	`422`	`if (TransactionIdIsValid(SnapshotDirty.xmin))`
`423`	`423`	`ereport(ERROR,`
`424`	`424`	`(errcode(ERRCODE_DATA_CORRUPTED),`
`425`		`-errmsg_internal("t_xmin is uncommitted in tuple to be updated")));`
	`425`	`+errmsg_internal("t_xmin %u is uncommitted in tuple (%u,%u) to be updated in table \"%s\"",`
	`426`	`+SnapshotDirty.xmin,`
	`427`	`+ItemPointerGetBlockNumber(&tuple->t_self),`
	`428`	`+ItemPointerGetOffsetNumber(&tuple->t_self),`
	`429`	`+RelationGetRelationName(relation))));`
`426`	`430`
`427`	`431`	`/*`
`428`	`432`	`* If tuple is being updated by other transaction then we`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit6197d7b

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam_handler.c`

0 commit comments