Commit6151cb7

committed

Replace static buf with palloc in str_time()

The function is used only once in the startup process, so the leakinto current memory context is harmless.This is a tiny step in making the server thread-safe.Reviewed-by: Robert HaasDiscussion:https://www.postgresql.org/message-id/7f86e06a-98c5-4ce3-8ec9-3885c8de0358@iki.fi

1 parent5bf948d commit6151cb7Copy full SHA for 6151cb7

File tree

-2

lines changed

-2

lines changed

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -5168,9 +5168,9 @@ BootStrapXLOG(uint32 data_checksum_version)`
`5168`	`5168`	`staticchar*`
`5169`	`5169`	`str_time(pg_time_ttnow)`
`5170`	`5170`	`{`
`5171`		`-staticcharbuf[128];`
	`5171`	`+char*buf=palloc(128);`
`5172`	`5172`
`5173`		`-pg_strftime(buf,sizeof(buf),`
	`5173`	`+pg_strftime(buf,128,`
`5174`	`5174`	`"%Y-%m-%d %H:%M:%S %Z",`
`5175`	`5175`	`pg_localtime(&tnow,log_timezone));`
`5176`	`5176`

Comments

(0)