NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit60ca2e8

committed

Silence compiler warnings from some older compilers.

Sincea117ceb, some older gcc versions issue "variable may be useduninitialized in this function" complaints for brin_summarize_range.Silence that using the same coding pattern as in bt_index_check_internal;arguably,a117ceb had too narrow a view of which compilers might givetrouble.Nathan Bossart and Tom Lane. Back-patch as the previous commit was.Discussion:https://postgr.es/m/20220601163537.GA2331988@nathanxps13

1 parenteeac7dd commit60ca2e8Copy full SHA for 60ca2e8

File tree

2 files changed

-1

lines changed

contrib/amcheck
- verify_nbtree.c
src/backend/access/brin
- brin.c

2 files changed

-1

lines changed

`‎contrib/amcheck/verify_nbtree.c‎`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -280,7 +280,7 @@ bt_index_check_internal(Oid indrelid, bool parentcheck, bool heapallindexed,`
`280`	`280`	`else`
`281`	`281`	`{`
`282`	`282`	`heaprel=NULL;`
`283`		`-/for "gcc -Og" https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78394 /`
	`283`	`+/Set these just to suppress "uninitialized variable" warnings /`
`284`	`284`	`save_userid=InvalidOid;`
`285`	`285`	`save_sec_context=-1;`
`286`	`286`	`save_nestlevel=-1;`

`‎src/backend/access/brin/brin.c‎`

Lines changed: 6 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -911,7 +911,13 @@ brin_summarize_range(PG_FUNCTION_ARGS)`
`911`	`911`	`save_nestlevel=NewGUCNestLevel();`
`912`	`912`	`}`
`913`	`913`	`else`
	`914`	`+{`
`914`	`915`	`heapRel=NULL;`
	`916`	`+/* Set these just to suppress "uninitialized variable" warnings */`
	`917`	`+save_userid=InvalidOid;`
	`918`	`+save_sec_context=-1;`
	`919`	`+save_nestlevel=-1;`
	`920`	`+}`
`915`	`921`
`916`	`922`	`indexRel=index_open(indexoid,ShareUpdateExclusiveLock);`
`917`	`923`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit60ca2e8

File tree

2 files changed

2 files changed

`‎contrib/amcheck/verify_nbtree.c‎`

`‎src/backend/access/brin/brin.c‎`

0 commit comments