NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit60b142b

committed

Fix a tiny race condition in predicate locking. Need to hold the lock while

examining the head of predicate locks list. Also, fix the comment ofRemoveTargetIfNoLongerUsed, it was neglected when we changed the way updatechains are handled.Kevin Grittner

1 parentc8ae318 commit60b142bCopy full SHA for 60b142b

File tree

1 file changed

-4

lines changed

src/backend/storage/lmgr
- predicate.c

1 file changed

-4

lines changed

`‎src/backend/storage/lmgr/predicate.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -1755,9 +1755,8 @@ CoarserLockCovers(const PREDICATELOCKTARGETTAG *newtargettag)`
`1755`	`1755`	`}`
`1756`	`1756`
`1757`	`1757`	`/*`
`1758`		`- * Check whether both the list of related predicate locks and the pointer to`
`1759`		`- * a prior version of the row (if this is a tuple lock target) are empty for`
`1760`		`- * a predicate lock target, and remove the target if they are.`
	`1758`	`+ * Check whether the list of related predicate locks is empty for a`
	`1759`	`+ * predicate lock target, and remove the target if it is.`
`1761`	`1760`	`*/`
`1762`	`1761`	`staticvoid`
`1763`	`1762`	`RemoveTargetIfNoLongerUsed(PREDICATELOCKTARGET*target,uint32targettaghash)`
`@@ -3120,11 +3119,11 @@ ClearOldPredicateLocks(void)`
`3120`	`3119`	`/*`
`3121`	`3120`	`* Loop through predicate locks on dummy transaction for summarized data.`
`3122`	`3121`	`*/`
	`3122`	`+LWLockAcquire(SerializablePredicateLockListLock,LW_SHARED);`
`3123`	`3123`	`predlock= (PREDICATELOCK*)`
`3124`	`3124`	`SHMQueueNext(&OldCommittedSxact->predicateLocks,`
`3125`	`3125`	`&OldCommittedSxact->predicateLocks,`
`3126`	`3126`	`offsetof(PREDICATELOCK,xactLink));`
`3127`		`-LWLockAcquire(SerializablePredicateLockListLock,LW_SHARED);`
`3128`	`3127`	`while (predlock)`
`3129`	`3128`	`{`
`3130`	`3129`	`PREDICATELOCK*nextpredlock;`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit60b142b

File tree

1 file changed

1 file changed

`‎src/backend/storage/lmgr/predicate.c`

0 commit comments