Commit605721f

committed

gen_node_support.pl: Mark location fields as type alias ParseLoc

Instead of the rather ugly type=int + name ~= location$, we now have amarker type for offset pointers or sizes that are only relevant when aquery text is included, which decreases the complexity required ingen_node_support.pl for handling these values.Author: Matthias van de Meent <boekewurm+postgres@gmail.com>Discussion:https://www.postgresql.org/message-id/flat/CAEze2WgrCiR3JZmWyB0YTc8HV7ewRdx13j0CqD6mVkYAW+SFGQ@mail.gmail.com

1 parent347758b commit605721fCopy full SHA for 605721f

File tree

+97

-87

lines changed

+97

-87

lines changed

Lines changed: 3 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -777,7 +777,7 @@ sub elem`
`777`	`777`	`print$eff"\tCOMPARE_BITMAPSET_FIELD($f);\n"`
`778`	`778`	`unless$equal_ignore;`
`779`	`779`	`}`
`780`		`-elsif ($teq'int' &&$f =~'location$')`
	`780`	`+elsif ($teq'ParseLoc')`
`781`	`781`	`{`
`782`	`782`	`print$cff"\tCOPY_LOCATION_FIELD($f);\n"unless$copy_ignore;`
`783`	`783`	`print$eff"\tCOMPARE_LOCATION_FIELD($f);\n"unless$equal_ignore;`
`@@ -1010,7 +1010,7 @@ sub elem`
`1010`	`1010`	`print$off"\tWRITE_BOOL_FIELD($f);\n";`
`1011`	`1011`	`print$rff"\tREAD_BOOL_FIELD($f);\n"unless$no_read;`
`1012`	`1012`	`}`
`1013`		`-elsif ($teq'int' &&$f =~'location$')`
	`1013`	`+elsif ($teq'ParseLoc')`
`1014`	`1014`	`{`
`1015`	`1015`	`print$off"\tWRITE_LOCATION_FIELD($f);\n";`
`1016`	`1016`	`print$rff"\tREAD_LOCATION_FIELD($f);\n"unless$no_read;`
`@@ -1303,7 +1303,7 @@ sub elem`
`1303`	`1303`	`print$jff"\tJUMBLE_NODE($f);\n"`
`1304`	`1304`	`unless$query_jumble_ignore;`
`1305`	`1305`	`}`
`1306`		`-elsif ($teq'int' &&$f =~'location$')`
	`1306`	`+elsif ($teq'ParseLoc')`
`1307`	`1307`	`{`
`1308`	`1308`	`# Track the node's location only if directly requested.`
`1309`	`1309`	`if ($query_jumble_location)`

Lines changed: 9 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -229,6 +229,15 @@ extern void copyObjectImpl(const void from);`
`229`	`229`	`externboolequal(constvoida,constvoidb);`
`230`	`230`
`231`	`231`
	`232`	`+/*`
	`233`	`+ * Typedef for parse location. This is just an int, but this way`
	`234`	`+ * gen_node_support.pl knows which fields should get special treatment for`
	`235`	`+ * location values.`
	`236`	`+ *`
	`237`	`+ * -1 is used for unknown.`
	`238`	`+ */`
	`239`	`+typedefintParseLoc;`
	`240`	`+`
`232`	`241`	`/*`
`233`	`242`	`* Typedefs for identifying qualifier selectivities, plan costs, and row`
`234`	`243`	`* counts as such. These are just plain "double"s, but declaring a variable`

Comments

(0)