NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit600c241

committed

Relax some asserts in merge join costing code

In the planner, it was possible, given an extreme enough case containing alarge number of joins for the number of estimated rows to become infinite.This could cause problems in initial_cost_mergejoin() where we performsome calculations based on those row estimates.A problem case, presented by Onder Kalaci showed an Assert failure froman Assert checking outerstartsel <= outerendsel. In his test case thiswas effectively NaN <= Inf, which is false. The NaN outerstartsel camefrom multiplying the infinite outer_path_rows by 0.0.In master, this problem was fixed bya90c950, however, that fix was tooinvasive for the backbranches. Here we just relax the Asserts to allowthem to pass. The worst that appears to happen from this is that we showNaN cost values and infinite row estimates in EXPLAIN. add_path() wouldhave had a hard time doing anything useful with such costs, but that doesnot really matter as if the row estimates were even close to accurate,such plan would not complete this side of the heat death of the universe.Reported-by: Onder KalaciBackpatch: 9.5 to 13Discussion:https://postgr.es/m/DM6PR21MB1211FF360183BCA901B27F04D80B0@DM6PR21MB1211.namprd21.prod.outlook.com

1 parente8d36f9 commit600c241Copy full SHA for 600c241

File tree

1 file changed

-4

lines changed

src/backend/optimizer/path
- costsize.c

1 file changed

-4

lines changed

`‎src/backend/optimizer/path/costsize.c`

Lines changed: 6 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2477,8 +2477,9 @@ initial_cost_mergejoin(PlannerInfo root, JoinCostWorkspace workspace,`
`2477`	`2477`	`outer_rows=clamp_row_est(outer_path_rows*outerendsel);`
`2478`	`2478`	`inner_rows=clamp_row_est(inner_path_rows*innerendsel);`
`2479`	`2479`
`2480`		`-Assert(outer_skip_rows <=outer_rows);`
`2481`		`-Assert(inner_skip_rows <=inner_rows);`
	`2480`	`+/* skip rows can become NaN when path rows has become infinite */`
	`2481`	`+Assert(outer_skip_rows <=outer_rows\|\|isnan(outer_skip_rows));`
	`2482`	`+Assert(inner_skip_rows <=inner_rows\|\|isnan(inner_skip_rows));`
`2482`	`2483`
`2483`	`2484`	`/*`
`2484`	`2485`	`* Readjust scan selectivities to account for above rounding. This is`
`@@ -2490,8 +2491,9 @@ initial_cost_mergejoin(PlannerInfo root, JoinCostWorkspace workspace,`
`2490`	`2491`	`outerendsel=outer_rows /outer_path_rows;`
`2491`	`2492`	`innerendsel=inner_rows /inner_path_rows;`
`2492`	`2493`
`2493`		`-Assert(outerstartsel <=outerendsel);`
`2494`		`-Assert(innerstartsel <=innerendsel);`
	`2494`	`+/* start sel can become NaN when path rows has become infinite */`
	`2495`	`+Assert(outerstartsel <=outerendsel\|\|isnan(outerstartsel));`
	`2496`	`+Assert(innerstartsel <=innerendsel\|\|isnan(innerstartsel));`
`2495`	`2497`
`2496`	`2498`	`/* cost of source data */`
`2497`	`2499`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit600c241

File tree

1 file changed

1 file changed

`‎src/backend/optimizer/path/costsize.c`

0 commit comments