NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5f81a48

committed

Fix memory overrun when querying pg_stat_slru

pg_stat_get_slru() in pgstatfuncs.c would point to one element after theend of the array PgStat_SLRUStats when finishing to scan its entries.This had no direct consequences as no data from the extra memory areawas read, but static analyzers would rightfully complain here. So let'sbe clean.While on it, this adds one regression test in the area reserved forsystem views.Reported-by: Alexander Kozhemyakin, via AddressSanitizerAuthor: Kyotaro HoriguchiDiscussion:https://postgr.es/m/17280-37da556e86032070@postgresql.orgBackpatch-through: 13

1 parent675cd76 commit5f81a48Copy full SHA for 5f81a48

File tree

3 files changed

+12

-1

lines changed

src
- backend/utils/adt
  - pgstatfuncs.c
- test/regress
  - expected
    - sysviews.out
  - sql
    - sysviews.sql

3 files changed

+12

-1

lines changed

`‎src/backend/utils/adt/pgstatfuncs.c`

Lines changed: 2 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1912,14 +1912,15 @@ pg_stat_get_slru(PG_FUNCTION_ARGS)`
`1912`	`1912`	`/* for each row */`
`1913`	`1913`	`Datumvalues[PG_STAT_GET_SLRU_COLS];`
`1914`	`1914`	`boolnulls[PG_STAT_GET_SLRU_COLS];`
`1915`		`-PgStat_SLRUStatsstat=stats[i];`
	`1915`	`+PgStat_SLRUStatsstat;`
`1916`	`1916`	`constchar*name;`
`1917`	`1917`
`1918`	`1918`	`name=pgstat_slru_name(i);`
`1919`	`1919`
`1920`	`1920`	`if (!name)`
`1921`	`1921`	`break;`
`1922`	`1922`
	`1923`	`+stat=stats[i];`
`1923`	`1924`	`MemSet(values,0,sizeof(values));`
`1924`	`1925`	`MemSet(nulls,0,sizeof(nulls));`
`1925`	`1926`

`‎src/test/regress/expected/sysviews.out`

Lines changed: 7 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -76,6 +76,13 @@ select count(*) >= 0 as ok from pg_prepared_xacts;`
`76`	`76`	`t`
`77`	`77`	`(1 row)`
`78`	`78`
	`79`	`+-- There will surely be at least one SLRU cache`
	`80`	`+select count(*) > 0 as ok from pg_stat_slru;`
	`81`	`+ ok`
	`82`	`+----`
	`83`	`+ t`
	`84`	`+(1 row)`
	`85`	`+`
`79`	`86`	`-- There must be only one record`
`80`	`87`	`select count(*) = 1 as ok from pg_stat_wal;`
`81`	`88`	`ok`

`‎src/test/regress/sql/sysviews.sql`

Lines changed: 3 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -37,6 +37,9 @@ select count(*) = 0 as ok from pg_prepared_statements;`
`37`	`37`	`-- See also prepared_xacts.sql`
`38`	`38`	`selectcount(*)>=0as okfrom pg_prepared_xacts;`
`39`	`39`
	`40`	`+-- There will surely be at least one SLRU cache`
	`41`	`+selectcount(*)>0as okfrom pg_stat_slru;`
	`42`	`+`
`40`	`43`	`-- There must be only one record`
`41`	`44`	`selectcount(*)=1as okfrom pg_stat_wal;`
`42`	`45`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5f81a48

File tree

3 files changed

3 files changed

`‎src/backend/utils/adt/pgstatfuncs.c`

`‎src/test/regress/expected/sysviews.out`

`‎src/test/regress/sql/sysviews.sql`

0 commit comments