NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5f6d735

Neil Conway

committed

Attached patch fixes two problems:

1) gendef works from inside visual studio - use a tempfile instead ofredirection, because for some reason you can't redirect dumpbin frominside (patch from Joachim Wieland)2) gendef must process only *.obj, or you get weird errors in some buildscenarios when it tries to process a logfileMagnus Hagander

1 parent840df51 commit5f6d735Copy full SHA for 5f6d735

File tree

1 file changed

-2

lines changed

src/tools/msvc
- gendef.pl

1 file changed

-2

lines changed

`‎src/tools/msvc/gendef.pl‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -10,9 +10,10 @@`
`10`	`10`
`11`	`11`	`print"Generating$defname.DEF from directory$ARGV[0]\n";`
`12`	`12`
`13`		`-while (<$ARGV[0]/*>) {`
	`13`	`+while (<$ARGV[0]/*.obj>) {`
`14`	`14`	`print".";`
`15`		`-open(F,"dumpbin /symbols$_\|") \|\|die"Could not open$_\n";`
	`15`	`+system("dumpbin /symbols /out:symbols.out$_ >NUL") &&die"Could not call dumpbin";`
	`16`	`+open(F,"<symbols.out") \|\|die"Could not open symbols.out for$_\n";`
`16`	`17`	`while (<F>) {`
`17`	`18`	`s///g;`
`18`	`19`	`nextunless/^\d/;`
`@@ -31,6 +32,7 @@`
`31`	`32`	`push@def,$pieces[6];`
`32`	`33`	`}`
`33`	`34`	`close(F);`
	`35`	`+unlink("symbols.out");`
`34`	`36`	`}`
`35`	`37`	`print"\n";`
`36`	`38`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5f6d735

File tree

1 file changed

1 file changed

`‎src/tools/msvc/gendef.pl‎`

0 commit comments