NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5f55fc5

committed

Demote pg_unreachable() in heapam to an assertion.

Commitd168b66, which overhauled index deletion, added apg_unreachable() to the end of a sort comparator used when sorting heapTIDs from an index page. This allows the compiler to applyoptimizations that assume that the heap TIDs from the index AM mustalways be unique.That doesn't seem like a good idea now, given recent reports ofcorruption involving duplicate TIDs in indexes on Postgres 14. Demoteto an assertion, just in case.Backpatch: 14-, where index deletion was overhauled.

1 parenta2a731d commit5f55fc5Copy full SHA for 5f55fc5

File tree

1 file changed

-1

lines changed

src/backend/access/heap
- heapam.c

1 file changed

-1

lines changed

`‎src/backend/access/heap/heapam.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -7586,7 +7586,7 @@ index_delete_sort_cmp(TM_IndexDelete deltid1, TM_IndexDelete deltid2)`
`7586`	`7586`	`return (pos1<pos2) ?-1 :1;`
`7587`	`7587`	`}`
`7588`	`7588`
`7589`		`-pg_unreachable();`
	`7589`	`+Assert(false);`
`7590`	`7590`
`7591`	`7591`	`return0;`
`7592`	`7592`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5f55fc5

File tree

1 file changed

1 file changed

`‎src/backend/access/heap/heapam.c`

0 commit comments