Commit5f4a1a0

committed

Throw a more on-point error for publications depending on columns.

Same as42b0412, except that the trouble case is a publicationWHERE clause that depends on a column.Again reported by Alexander Lakhin. Back-patch to v15 wherewe added publication WHERE clauses.Discussion:https://postgr.es/m/548a47bc-87ae-b3df-c6a2-60b9966f808b@gmail.com

1 parentda55e4c commit5f4a1a0Copy full SHA for 5f4a1a0

File tree

+14

-1

lines changed

+14

-1

lines changed

Lines changed: 14 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -12816,6 +12816,20 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`12816`	`12816`	`RememberStatisticsForRebuilding(foundObject.objectId, tab);`
`12817`	`12817`	`break;`
`12818`	`12818`
	`12819`	`+case OCLASS_PUBLICATION_REL:`
	`12820`	`+`
	`12821`	`+/*`
	`12822`	`+ * Column reference in a PUBLICATION ... FOR TABLE ... WHERE`
	`12823`	`+ * clause. Same issues as above. FIXME someday.`
	`12824`	`+ */`
	`12825`	`+ereport(ERROR,`
	`12826`	`+(errcode(ERRCODE_FEATURE_NOT_SUPPORTED),`
	`12827`	`+ errmsg("cannot alter type of a column used by a publication WHERE clause"),`
	`12828`	`+ errdetail("%s depends on column \"%s\"",`
	`12829`	`+ getObjectDescription(&foundObject, false),`
	`12830`	`+ colName)));`
	`12831`	`+break;`
	`12832`	`+`
`12819`	`12833`	`case OCLASS_TYPE:`
`12820`	`12834`	`case OCLASS_CAST:`
`12821`	`12835`	`case OCLASS_COLLATION:`
`@@ -12845,7 +12859,6 @@ ATExecAlterColumnType(AlteredTableInfo *tab, Relation rel,`
`12845`	`12859`	`case OCLASS_PARAMETER_ACL:`
`12846`	`12860`	`case OCLASS_PUBLICATION:`
`12847`	`12861`	`case OCLASS_PUBLICATION_NAMESPACE:`
`12848`		`-case OCLASS_PUBLICATION_REL:`
`12849`	`12862`	`case OCLASS_SUBSCRIPTION:`
`12850`	`12863`	`case OCLASS_TRANSFORM:`
`12851`	`12864`

Comments

(0)