Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5f36096

Browse files
committed
Add a comment noting that FDWs don't have to implement EXCEPT or LIMIT TO.
postgresImportForeignSchema pays attention to IMPORT's EXCEPT and LIMIT TOoptions, but only as an efficiency hack, not for correctness' sake. TheFDW documentation does explain that, but someone using postgres_fdw.cas a coding guide might not remember it, so let's add a comment here.Per question from Regina Obe.
1 parent0dab5ef commit5f36096

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

‎contrib/postgres_fdw/postgres_fdw.c

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2892,7 +2892,11 @@ postgresImportForeignSchema(ImportForeignSchemaStmt *stmt, Oid serverOid)
28922892

28932893
/*
28942894
* Fetch all table data from this schema, possibly restricted by
2895-
* EXCEPT or LIMIT TO.
2895+
* EXCEPT or LIMIT TO. (We don't actually need to pay any attention
2896+
* to EXCEPT/LIMIT TO here, because the core code will filter the
2897+
* statements we return according to those lists anyway. But it
2898+
* should save a few cycles to not process excluded tables in the
2899+
* first place.)
28962900
*
28972901
* Note: because we run the connection with search_path restricted to
28982902
* pg_catalog, the format_type() and pg_get_expr() outputs will always

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp