NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5f2e09b

committed

Further fix thinko in plpgsql memory leak fix.

There's a second call of get_eval_mcontext() that should also beget_stmt_mcontext(). This is actually dead code, since nointeresting allocations happen before switching back to theoriginal context, but we should keep it in sync with the othercall to forestall possible future bugs.Discussion:https://postgr.es/m/f075f7be-c654-9aa8-3ffc-e9214622f02a@enterprisedb.com

1 parentea80d8d commit5f2e09bCopy full SHA for 5f2e09b

File tree

1 file changed

-1

lines changed

src/pl/plpgsql/src
- pl_exec.c

1 file changed

-1

lines changed

`‎src/pl/plpgsql/src/pl_exec.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2282,7 +2282,7 @@ exec_stmt_call(PLpgSQL_execstate estate, PLpgSQL_stmt_call stmt)`
`2282`	`2282`	`row->varnos= (int)palloc(sizeof(int)list_length(funcargs));`
`2283`	`2283`
`2284`	`2284`	`if (!local_plan)`
`2285`		`-MemoryContextSwitchTo(get_eval_mcontext(estate));`
	`2285`	`+MemoryContextSwitchTo(get_stmt_mcontext(estate));`
`2286`	`2286`
`2287`	`2287`	`/*`
`2288`	`2288`	`* Examine procedure's argument list. Each output arg position`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5f2e09b

File tree

1 file changed

1 file changed

`‎src/pl/plpgsql/src/pl_exec.c`

0 commit comments