NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5f1ab46

committed

Suppress a couple of compiler warnings seen with older gcc versions.

To wit,bgworker.c: In function `RegisterDynamicBackgroundWorker':bgworker.c:761: warning: `generation' might be used uninitialized in this functiondsm_impl.c: In function `dsm_impl_op':dsm_impl.c:197: warning: control reaches end of non-void functionNeither of these represent actual bugs, but we may as well tweak the codeso that more compilers can tell that. This won't change the generated codeon compilers that do recognize that the cases are unreachable.

1 parent2c66f99 commit5f1ab46Copy full SHA for 5f1ab46

File tree

2 files changed

-3

lines changed

src/backend
- postmaster
  - bgworker.c
- storage/ipc
  - dsm_impl.c

2 files changed

-3

lines changed

`‎src/backend/postmaster/bgworker.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -758,7 +758,7 @@ RegisterDynamicBackgroundWorker(BackgroundWorker *worker,`
`758`	`758`	`{`
`759`	`759`	`intslotno;`
`760`	`760`	`boolsuccess= false;`
`761`		`-uint64generation;`
	`761`	`+uint64generation=0;`
`762`	`762`
`763`	`763`	`/*`
`764`	`764`	`* We can't register dynamic background workers from the postmaster.`

`‎src/backend/storage/ipc/dsm_impl.c`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -191,9 +191,11 @@ dsm_impl_op(dsm_op op, dsm_handle handle, uint64 request_size,`
`191`	`191`	`returndsm_impl_mmap(op,handle,request_size,impl_private,`
`192`	`192`	`mapped_address,mapped_size,elevel);`
`193`	`193`	`#endif`
	`194`	`+default:`
	`195`	`+elog(ERROR,"unexpected dynamic shared memory type: %d",`
	`196`	`+dynamic_shared_memory_type);`
	`197`	`+return false;`
`194`	`198`	`}`
`195`		`-elog(ERROR,"unexpected dynamic shared memory type: %d",`
`196`		`-dynamic_shared_memory_type);`
`197`	`199`	`}`
`198`	`200`
`199`	`201`	`/*`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5f1ab46

File tree

2 files changed

2 files changed

`‎src/backend/postmaster/bgworker.c`

`‎src/backend/storage/ipc/dsm_impl.c`

0 commit comments