Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5ee96b3

Browse files
committed
Make pg_regress.c unset PGDATABASE during make installcheck.
For the most part, we leave libpq-controlling environment variablesalone during "make installcheck", reasoning that connecting to theserver the user expects us to connect to may depend on those variables.But that argument doesn't apply to PGDATABASE, since we always wantto connect to a specific database name within the server. And failingto unset it causes certain ECPG tests to fail, as various people havecomplained of in the past. So let's unset it.Possibly this should be back-patched, but I'm disinclined to do thatright before 12.0 release. Maybe later.Discussion:https://postgr.es/m/20180318205548.2akxjqvo7hrk5wbc@alap3.anarazel.deDiscussion:https://postgr.es/m/E1bOum4-0002EA-2y@gemulon.postgresql.org
1 parent3f6b3be commit5ee96b3

File tree

1 file changed

+8
-0
lines changed

1 file changed

+8
-0
lines changed

‎src/test/regress/pg_regress.c

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -861,6 +861,14 @@ initialize_environment(void)
861861
if (user!=NULL)
862862
doputenv("PGUSER",user);
863863

864+
/*
865+
* However, we *don't* honor PGDATABASE, since we certainly don't wish
866+
* to connect to whatever database the user might like as default.
867+
* (Most tests override PGDATABASE anyway, but there are some ECPG
868+
* test cases that don't.)
869+
*/
870+
unsetenv("PGDATABASE");
871+
864872
/*
865873
* Report what we're connecting to
866874
*/

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp