Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5edeb57

Browse files
committed
Add some missing PGDLLIMPORT markings
Three variables in pqsignal.h (UnBlockSig, BlockSig and StartupBlockSig)were not marked with PGDLLIMPORT, as they are declared in a way thatprevents mark_pgdllimport.pl to detect them. These variables areredefined in a style more consistent with the other headers, allowingthe script to find and mark them.PGDLLIMPORT was missing for __pg_log_level in logging.h, so add itback. The marking got accidentally removed in9a374b7, just after itsaddition in8ec5694.While on it, add a comment in mark_pgdllimport.pl explaining what arethe arguments needed by the script (aka a list of header paths).Reported-by: Andres FreundDiscussion:https://postgr.es/m/20220506234924.6mxxotl3xl63db3l@alap3.anarazel.de
1 parent6bfecf3 commit5edeb57

File tree

3 files changed

+6
-5
lines changed

3 files changed

+6
-5
lines changed

‎src/include/common/logging.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,7 +51,7 @@ enum pg_log_level
5151
/*
5252
* __pg_log_level is the minimum log level that will actually be shown.
5353
*/
54-
externenumpg_log_level__pg_log_level;
54+
externPGDLLIMPORTenumpg_log_level__pg_log_level;
5555

5656
/*
5757
* A log message can have several parts. The primary message is required,

‎src/include/libpq/pqsignal.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,9 +30,9 @@ extern intpqsigsetmask(int mask);
3030
#definesigdelset(set,signum)(*(set) &= ~(sigmask(signum)))
3131
#endif/* WIN32 */
3232

33-
externsigset_tUnBlockSig,
34-
BlockSig,
35-
StartupBlockSig;
33+
externPGDLLIMPORTsigset_tUnBlockSig;
34+
externPGDLLIMPORTsigset_tBlockSig;
35+
externPGDLLIMPORTsigset_tStartupBlockSig;
3636

3737
externvoidpqinitmask(void);
3838

‎src/tools/mark_pgdllimport.pl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,8 @@
1212
# smart and may not catch all cases.
1313
#
1414
# It's probably a good idea to run pgindent on any files that this
15-
# script modifies before committing.
15+
# script modifies before committing. This script uses as arguments
16+
# a list of the header files to scan for the markings.
1617
#
1718
# Portions Copyright (c) 1996-2022, PostgreSQL Global Development Group
1819
# Portions Copyright (c) 1994, Regents of the University of California

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp