NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5ecd018

committed

Fix comments about bgworker registration before MaxBackends initialization

Since6bc8ef0, InitializeMaxBackends() has used max_worker_processesinstead of adapting MaxBackends to the number of background workersregistered by modules loaded in shared_preload_libraries (at this time,bgworkers were only static, but gained dynamic capabilities as a matterof supporting parallel queries meaning that a control cap wasnecessary).Some comments referred to the past registration logic, making themconfusing and incorrect, so fix these.Some of the out-of-core modules that could be loaded in this pathsometimes like to manipulate dynamically some of the resource-relatedGUCs for their own needs, this commit adds a note about that.Author: Nathan BossartDiscussion:https://postgr.es/m/20220127181815.GA551692@nathanxps13

1 parentbf42fca commit5ecd018Copy full SHA for 5ecd018

File tree

2 files changed

-9

lines changed

src/backend
- postmaster
  - postmaster.c
- utils/init
  - postinit.c

2 files changed

-9

lines changed

`‎src/backend/postmaster/postmaster.c`

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -1014,10 +1014,8 @@ PostmasterMain(int argc, char *argv[])`
`1014`	`1014`	`LocalProcessControlFile(false);`
`1015`	`1015`
`1016`	`1016`	`/*`
`1017`		`- * Register the apply launcher. Since it registers a background worker,`
`1018`		`- * it needs to be called before InitializeMaxBackends(), and it's probably`
`1019`		`- * a good idea to call it before any modules had chance to take the`
`1020`		`- * background worker slots.`
	`1017`	`+ * Register the apply launcher. It's probably a good idea to call this`
	`1018`	`+ * before any modules had a chance to take the background worker slots.`
`1021`	`1019`	`*/`
`1022`	`1020`	`ApplyLauncherRegister();`
`1023`	`1021`
`@@ -1038,8 +1036,8 @@ PostmasterMain(int argc, char *argv[])`
`1038`	`1036`	`#endif`
`1039`	`1037`
`1040`	`1038`	`/*`
`1041`		`- * Now that loadable modules have had their chance toregister background`
`1042`		`- *workers,calculate MaxBackends.`
	`1039`	`+ * Now that loadable modules have had their chance toalter any GUCs,`
	`1040`	`+ * calculate MaxBackends.`
`1043`	`1041`	`*/`
`1044`	`1042`	`InitializeMaxBackends();`
`1045`	`1043`

`‎src/backend/utils/init/postinit.c`

Lines changed: 2 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -483,9 +483,8 @@ pg_split_opts(char *argv, int argcp, const char *optstr)`
`483`	`483`	`/*`
`484`	`484`	`* Initialize MaxBackends value from config options.`
`485`	`485`	`*`
`486`		`- * This must be called after modules have had the chance to register background`
`487`		`- * workers in shared_preload_libraries, and before shared memory size is`
`488`		`- * determined.`
	`486`	`+ * This must be called after modules have had the chance to alter GUCs in`
	`487`	`+ * shared_preload_libraries and before shared memory size is determined.`
`489`	`488`	`*`
`490`	`489`	`* Note that in EXEC_BACKEND environment, the value is passed down from`
`491`	`490`	`* postmaster to subprocesses via BackendParameters in SubPostmasterMain; only`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5ecd018

File tree

2 files changed

2 files changed

`‎src/backend/postmaster/postmaster.c`

`‎src/backend/utils/init/postinit.c`

0 commit comments