NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5ebd262

committed

waldump: fix use-after-free in search_directory().

After closedir() dirent->d_name is not valid anymore. As there alerady are afew places relying on the limited lifetime of pg_waldump, do so here as well,and just pg_strdup() the string.The bug was introduced infc49e24.Found by UBSan, run locally.Backpatch: 11-, likefc49e24 itself.

1 parent5ca2aa2 commit5ebd262Copy full SHA for 5ebd262

File tree

1 file changed

-1

lines changed

src/bin/pg_waldump
- pg_waldump.c

1 file changed

-1

lines changed

`‎src/bin/pg_waldump/pg_waldump.c`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -180,7 +180,7 @@ search_directory(const char directory, const char fname)`
`180`	`180`	`if (IsXLogFileName(xlde->d_name))`
`181`	`181`	`{`
`182`	`182`	`fd=open_file_in_directory(directory,xlde->d_name);`
`183`		`-fname=xlde->d_name;`
	`183`	`+fname=pg_strdup(xlde->d_name);`
`184`	`184`	`break;`
`185`	`185`	`}`
`186`	`186`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5ebd262

File tree

1 file changed

1 file changed

`‎src/bin/pg_waldump/pg_waldump.c`

0 commit comments