NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5eaa0e9

committed

Remove ancient special case code for adding oid columns

The special handling of negative attribute numbers inATExecAddColumn() was introduced to support SET WITH OIDS (commit6d1e361). But that feature doesn't exist anymore, so we can revertto the previous, simpler version. In passing, also remove an obsoletecomment about OID support.Reviewed-by: Alvaro Herrera <alvherre@alvh.no-ip.org>Discussion:https://www.postgresql.org/message-id/flat/52a125e4-ff9a-95f5-9f61-b87cf447e4da@eisentraut.org

1 parentadf333b commit5eaa0e9Copy full SHA for 5eaa0e9

File tree

1 file changed

-4

lines changed

src/backend/commands
- tablecmds.c

1 file changed

-4

lines changed

`‎src/backend/commands/tablecmds.c`

Lines changed: 3 additions & 4 deletions

Original file line number	Diff line number	Diff line change
`@@ -2450,8 +2450,7 @@ MergeAttributes(List schema, List supers, char relpersistence,`
`2450`	`2450`
`2451`	`2451`	`/*`
`2452`	`2452`	`* Scan the parents left-to-right, and merge their attributes to form a`
`2453`		`- * list of inherited attributes (inhSchema). Also check to see if we need`
`2454`		`- * to inherit an OID column.`
	`2453`	`+ * list of inherited attributes (inhSchema).`
`2455`	`2454`	`*/`
`2456`	`2455`	`child_attno = 0;`
`2457`	`2456`	`foreach(entry, supers)`
`@@ -6945,7 +6944,7 @@ ATExecAddColumn(List *wqueue, AlteredTableInfo tab, Relation rel,`
`6945`	`6944`	`attribute.attrelid = myrelid;`
`6946`	`6945`	`namestrcpy(&(attribute.attname), colDef->colname);`
`6947`	`6946`	`attribute.atttypid = typeOid;`
`6948`		`-attribute.attstattarget =(newattnum > 0) ? -1 : 0;`
	`6947`	`+attribute.attstattarget =-1;`
`6949`	`6948`	`attribute.attlen = tform->typlen;`
`6950`	`6949`	`attribute.attnum = newattnum;`
`6951`	`6950`	`if (list_length(colDef->typeName->arrayBounds) > PG_INT16_MAX)`
`@@ -7068,7 +7067,7 @@ ATExecAddColumn(List *wqueue, AlteredTableInfo tab, Relation rel,`
`7068`	`7067`	`* is certainly not going to touch them. System attributes don't have`
`7069`	`7068`	`* interesting defaults, either.`
`7070`	`7069`	`*/`
`7071`		`-if (RELKIND_HAS_STORAGE(relkind) && attribute.attnum > 0)`
	`7070`	`+if (RELKIND_HAS_STORAGE(relkind))`
`7072`	`7071`	`{`
`7073`	`7072`	`/*`
`7074`	`7073`	`* For an identity column, we can't use build_column_default(),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5eaa0e9

File tree

1 file changed

1 file changed

`‎src/backend/commands/tablecmds.c`

0 commit comments