Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

Commit5e5fa32

Browse files
committed
Remove portability hazard in unsafe_tests/sql/guc_privs.sql.
This new-in-v15 test case assumed it could set max_stack_depth as highas 2MB. You might think that'd be true on any modern platform butyou'd be wrong, as I found out while experimenting with NetBSD/hppa.This test is about privileges not platform capabilities, so there seemsno need to use any value greater than the 100kB setting already usedin a couple of places in the core regression tests. There's certainlyno call to expect people to raise their platform's default ulimit justto run this test.
1 parent6029861 commit5e5fa32

File tree

2 files changed

+4
-4
lines changed

2 files changed

+4
-4
lines changed

‎src/test/modules/unsafe_tests/expected/guc_privs.out

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -436,9 +436,9 @@ ERROR: parameter "autovacuum_work_mem" cannot be changed now
436436
ALTER SYSTEM RESET temp_file_limit; -- ok
437437
SET TimeZone = 'Europe/Helsinki'; -- ok
438438
RESET TimeZone; -- ok
439-
SET max_stack_depth =2048; -- ok, privileges have been granted
439+
SET max_stack_depth ='100kB'; -- ok, privileges have been granted
440440
RESET max_stack_depth; -- ok, privileges have been granted
441-
ALTER SYSTEM SET max_stack_depth =2048; -- ok, privileges have been granted
441+
ALTER SYSTEM SET max_stack_depth ='100kB'; -- ok, privileges have been granted
442442
ALTER SYSTEM RESET max_stack_depth; -- ok, privileges have been granted
443443
SET lc_messages = 'C'; -- fail, insufficient privileges
444444
ERROR: permission denied to set parameter "lc_messages"

‎src/test/modules/unsafe_tests/sql/guc_privs.sql

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,9 +176,9 @@ SET autovacuum_work_mem = 50; -- cannot be changed now
176176
ALTER SYSTEM RESET temp_file_limit;-- ok
177177
SET TimeZone='Europe/Helsinki';-- ok
178178
RESET TimeZone;-- ok
179-
SET max_stack_depth=2048;-- ok, privileges have been granted
179+
SET max_stack_depth='100kB';-- ok, privileges have been granted
180180
RESET max_stack_depth;-- ok, privileges have been granted
181-
ALTER SYSTEMSET max_stack_depth=2048;-- ok, privileges have been granted
181+
ALTER SYSTEMSET max_stack_depth='100kB';-- ok, privileges have been granted
182182
ALTER SYSTEM RESET max_stack_depth;-- ok, privileges have been granted
183183
SET lc_messages='C';-- fail, insufficient privileges
184184
RESET lc_messages;-- fail, insufficient privileges

0 commit comments

Comments
 (0)
[8]ページ先頭
©2009-2025 Movatter.jp