forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit5e51297
committed
Some code review for xml.c:
Add some more xml_init() calls that might not be necessary, but seem like agood idea to avoid possible problems like we saw in xmlelement().Fix unsafe assumption that you can keep using the tupledesc of a relcacheentry you don't have open.Add missing error checks for SearchSysCache failure.Get rid of handwritten array traversal in xpath() and O(N^2), broken-for-nullsarray access code in map_sql_value_to_xml_value(), in favor of usingdeconstruct_array.Manually adjust a lot of line breaks in places where the code is otherwisegonna look pretty awful after pg_indent hacks it up (original author seems tohave liked to lay out code for a 200-column window).1 parent85f807d commit5e51297
1 file changed
+314
-207
lines changed0 commit comments
Comments
(0)