forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit5e0b1ae
committed
Make detach-partition-concurrently-3 less timing-sensitive
This recently added test has shown to be too sensitive to timing whensending a cancel to a session waiting for a lock.We fix this by running a no-op query in the blocked session immediatelyafter the cancel; this avoids the session that sent the cancel sendinganother query immediately before the cancel has been reported.Idea by Noah Misch.With that fix, we sometimes see that the cancel error report is shownonly relative to the step that is cancelled, instead of together withthe step that sends the cancel. To increase the probability that bothsteps are shown togeter, add a 0.1s sleep to the cancel. In normalconditions this appears sufficient to silence most failures, but we'llsee that the slower buildfarm members say about it.Reported-by: Takamichi Osumi <osumi.takamichi@fujitsu.com>Discussion:https://postgr.es/m/OSBPR01MB4888C4ABA361C7E81094AC66ED269@OSBPR01MB4888.jpnprd01.prod.outlook.com1 parent8673a37 commit5e0b1ae
File tree
2 files changed
+115
-91
lines changed- src/test/isolation
- expected
- specs
2 files changed
+115
-91
lines changed0 commit comments
Comments
(0)