NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5e07d3d

committed

pgstat: fix small bug in pgstat_drop_relation().

Just after committing5891c7a, a test running with debug_discard_caches=1failed locally...pgstat_drop_relation() neither checked pgstat_should_count_relation() norcalled pgstat_prep_relation_pending(). With debug_discard_caches=1rel->pgstat_info wasn't set up, leading pg_stat_get_xact_tuples_inserted()spuriously still returning > 0 while in the transaction dropping the table.

1 parent81ae9e6 commit5e07d3dCopy full SHA for 5e07d3d

File tree

1 file changed

-3

lines changed

src/backend/utils/activity
- pgstat_relation.c

1 file changed

-3

lines changed

`‎src/backend/utils/activity/pgstat_relation.c`

Lines changed: 6 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -180,18 +180,21 @@ void`
`180`	`180`	`pgstat_drop_relation(Relationrel)`
`181`	`181`	`{`
`182`	`182`	`intnest_level=GetCurrentTransactionNestLevel();`
`183`		`-PgStat_TableStatus*pgstat_info=rel->pgstat_info;`
	`183`	`+PgStat_TableStatus*pgstat_info;`
`184`	`184`
`185`	`185`	`pgstat_drop_transactional(PGSTAT_KIND_RELATION,`
`186`	`186`	`rel->rd_rel->relisshared ?InvalidOid :MyDatabaseId,`
`187`	`187`	`RelationGetRelid(rel));`
`188`	`188`
	`189`	`+if (!pgstat_should_count_relation(rel))`
	`190`	`+return;`
	`191`	`+`
`189`	`192`	`/*`
`190`	`193`	`* Transactionally set counters to 0. That ensures that accesses to`
`191`	`194`	`* pg_stat_xact_all_tables inside the transaction show 0.`
`192`	`195`	`*/`
`193`		`-if (pgstat_info&&`
`194`		`-pgstat_info->trans!=NULL&&`
	`196`	`+pgstat_info=rel->pgstat_info;`
	`197`	`+if (pgstat_info->trans&&`
`195`	`198`	`pgstat_info->trans->nest_level==nest_level)`
`196`	`199`	`{`
`197`	`200`	`save_truncdrop_counters(pgstat_info->trans, true);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5e07d3d

File tree

1 file changed

1 file changed

`‎src/backend/utils/activity/pgstat_relation.c`

0 commit comments