NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5df319f

committed

Fix memory leak and inefficiency in CREATE DATABASE ... STRATEGY WAL_LOG

RelationCopyStorageUsingBuffer() did not free the strategies used to accessthe source / target relation. They memory was released at the end of thetransaction, but when using a template database with a lot of relations, thetemporary leak can become big prohibitively big.RelationCopyStorageUsingBuffer() acquired the buffer for the target relationwith RBM_NORMAL, therefore requiring a read of a block guaranteed to bezero. Use RBM_ZERO_AND_LOCK instead.Reviewed-by: Robert Haas <robertmhaas@gmail.com>Discussion:https://postgr.es/m/20230321070113.o2vqqxogjykwgfrr@awork3.anarazel.deBackpatch: 15-, where STRATEGY WAL_LOG was introduced

1 parentbbc1376 commit5df319fCopy full SHA for 5df319f

File tree

1 file changed

-3

lines changed

src/backend/storage/buffer
- bufmgr.c

1 file changed

-3

lines changed

`‎src/backend/storage/buffer/bufmgr.c`

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -3833,11 +3833,9 @@ RelationCopyStorageUsingBuffer(RelFileLocator srclocator,`
`3833`	`3833`	`LockBuffer(srcBuf,BUFFER_LOCK_SHARE);`
`3834`	`3834`	`srcPage=BufferGetPage(srcBuf);`
`3835`	`3835`
`3836`		`-/* Use P_NEW to extend the destination relation. */`
`3837`	`3836`	`dstBuf=ReadBufferWithoutRelcache(dstlocator,forkNum,blkno,`
`3838`		`-RBM_NORMAL,bstrategy_dst,`
	`3837`	`+RBM_ZERO_AND_LOCK,bstrategy_dst,`
`3839`	`3838`	`permanent);`
`3840`		`-LockBuffer(dstBuf,BUFFER_LOCK_EXCLUSIVE);`
`3841`	`3839`	`dstPage=BufferGetPage(dstBuf);`
`3842`	`3840`
`3843`	`3841`	`START_CRIT_SECTION();`
`@@ -3855,6 +3853,9 @@ RelationCopyStorageUsingBuffer(RelFileLocator srclocator,`
`3855`	`3853`	`UnlockReleaseBuffer(dstBuf);`
`3856`	`3854`	`UnlockReleaseBuffer(srcBuf);`
`3857`	`3855`	`}`
	`3856`	`+`
	`3857`	`+FreeAccessStrategy(bstrategy_src);`
	`3858`	`+FreeAccessStrategy(bstrategy_dst);`
`3858`	`3859`	`}`
`3859`	`3860`
`3860`	`3861`	`/* ---------------------------------------------------------------------`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5df319f

File tree

1 file changed

1 file changed

`‎src/backend/storage/buffer/bufmgr.c`

0 commit comments