Commit5d8c5a1

macdice

authored and

pull[bot]

committed

Don't leak a signalfd when using latches in the postmaster.

At the time of commit6a2a70a we didn't use latch infrastructure inthe postmaster. We're planning to start doing that, so we'd better makesure that the signalfd inherited from a postmaster is not duplicated andthen leaked in the child.Reviewed-by: Andres Freund <andres@anarazel.de>Reviewed-by: Justin Pryzby <pryzby@telsasoft.com>Discussion:https://postgr.es/m/CA%2BhUKG%2BZ-HpOj1JsO9eWUP%2Bar7npSVinsC_npxSy%2BjdOMsx%3DGg%40mail.gmail.com

1 parentf93b8ce commit5d8c5a1Copy full SHA for 5d8c5a1

File tree

1 file changed

+16

-0

lines changed

src/backend/storage/ipc
- latch.c

1 file changed

+16

-0

lines changed

`‎src/backend/storage/ipc/latch.c`

Lines changed: 16 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -283,6 +283,22 @@ InitializeLatchSupport(void)`
`283`	`283`	`#ifdefWAIT_USE_SIGNALFD`
`284`	`284`	`sigset_tsignalfd_mask;`
`285`	`285`
	`286`	`+if (IsUnderPostmaster)`
	`287`	`+{`
	`288`	`+/*`
	`289`	`+ * It would probably be safe to re-use the inherited signalfd since`
	`290`	`+ * signalfds only see the current process's pending signals, but it`
	`291`	`+ * seems less surprising to close it and create our own.`
	`292`	`+ */`
	`293`	`+if (signal_fd!=-1)`
	`294`	`+{`
	`295`	`+/* Release postmaster's signal FD; ignore any error */`
	`296`	`+(void)close(signal_fd);`
	`297`	`+signal_fd=-1;`
	`298`	`+ReleaseExternalFD();`
	`299`	`+}`
	`300`	`+}`
	`301`	`+`
`286`	`302`	`/* Block SIGURG, because we'll receive it through a signalfd. */`
`287`	`303`	`sigaddset(&UnBlockSig,SIGURG);`
`288`	`304`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5d8c5a1

File tree

1 file changed

1 file changed

`‎src/backend/storage/ipc/latch.c`

0 commit comments