NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5d3500d

committed

Acquire properly session-level lock on new index in REINDEX CONCURRENTLY

In the first transaction run for REINDEX CONCURRENTLY, a thinko in theexisting logic caused two session locks to be taken on the old index,causing the session lock on the newly-created index to be missed. Thismade possible concurrent DDL commands (like ALTER INDEX) on the newindex while REINDEX CONCURRENTLY was processing from the point where thefirst internal transaction committed.This issue has been discovered while digging into another bug.Author: Michael PaquierDiscussion:https://postgr.es/m/20191021074323.GB1869@paquier.xyzBackpatch-through: 12

1 parent508e84d commit5d3500dCopy full SHA for 5d3500d

File tree

1 file changed

-2

lines changed

src/backend/commands
- indexcmds.c

1 file changed

-2

lines changed

`‎src/backend/commands/indexcmds.c`

Lines changed: 5 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -2960,8 +2960,11 @@ ReindexRelationConcurrently(Oid relationOid, int options)`
`2960`	`2960`	`indexId,`
`2961`	`2961`	`concurrentName);`
`2962`	`2962`
`2963`		`-/* Now open the relation of the new index, a lock is also needed on it */`
`2964`		`-newIndexRel=index_open(indexId,ShareUpdateExclusiveLock);`
	`2963`	`+/*`
	`2964`	`+ * Now open the relation of the new index, a session-level lock is`
	`2965`	`+ * also needed on it.`
	`2966`	`+ */`
	`2967`	`+newIndexRel=index_open(newIndexId,ShareUpdateExclusiveLock);`
`2965`	`2968`
`2966`	`2969`	`/*`
`2967`	`2970`	`* Save the list of OIDs and locks in private context`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5d3500d

File tree

1 file changed

1 file changed

`‎src/backend/commands/indexcmds.c`

0 commit comments