NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5d2adf0

committed

Blind try to fix portability issue in commit8f93bd8 et al.

The S/390 members of the buildfarm are showing failures indicatingthat they're having trouble with the rint() calls I added yesterday.There's no good reason for that, and I wonder if it is a compiler bugsimilar to the one we worked around ind9476b8. Try to fix it usingthe same method as before, namely to store the result of rint() backinto a "double" variable rather than immediately converting to int64.(This isn't entirely waving a dead chicken, since on machines withwider-than-double float registers, the extra store forces a widthconversion. I don't know if S/390 is like that, but it seems worthtrying.)In passing, merge duplicate ereport() calls in float8_timestamptz().Per buildfarm.

1 parent806091c commit5d2adf0Copy full SHA for 5d2adf0

File tree

1 file changed

-8

lines changed

src/backend/utils/adt
- timestamp.c

1 file changed

-8

lines changed

`‎src/backend/utils/adt/timestamp.c`

Lines changed: 6 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -773,12 +773,8 @@ float8_timestamptz(PG_FUNCTION_ARGS)`
`773`	`773`	`{`
`774`	`774`	`/* Out of range? */`
`775`	`775`	`if (seconds<`
`776`		`-(float8)SECS_PER_DAY* (DATETIME_MIN_JULIAN-UNIX_EPOCH_JDATE))`
`777`		`-ereport(ERROR,`
`778`		`-(errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),`
`779`		`-errmsg("timestamp out of range: \"%g\"",seconds)));`
`780`		`-`
`781`		`-if (seconds >=`
	`776`	`+(float8)SECS_PER_DAY* (DATETIME_MIN_JULIAN-UNIX_EPOCH_JDATE)`
	`777`	`+\|\|seconds >=`
`782`	`778`	`(float8)SECS_PER_DAY* (TIMESTAMP_END_JULIAN-UNIX_EPOCH_JDATE))`
`783`	`779`	`ereport(ERROR,`
`784`	`780`	`(errcode(ERRCODE_DATETIME_VALUE_OUT_OF_RANGE),`
`@@ -788,7 +784,8 @@ float8_timestamptz(PG_FUNCTION_ARGS)`
`788`	`784`	`seconds-= ((POSTGRES_EPOCH_JDATE-UNIX_EPOCH_JDATE)*SECS_PER_DAY);`
`789`	`785`
`790`	`786`	`#ifdefHAVE_INT64_TIMESTAMP`
`791`		`-result=rint(seconds*USECS_PER_SEC);`
	`787`	`+seconds=rint(seconds*USECS_PER_SEC);`
	`788`	`+result= (int64)seconds;`
`792`	`789`	`#else`
`793`	`790`	`result=seconds;`
`794`	`791`	`#endif`
`@@ -1624,9 +1621,10 @@ make_interval(PG_FUNCTION_ARGS)`
`1624`	`1621`	`result->day=weeks*7+days;`
`1625`	`1622`
`1626`	`1623`	`#ifdefHAVE_INT64_TIMESTAMP`
	`1624`	`+secs=rint(secs*USECS_PER_SEC);`
`1627`	`1625`	`result->time=hours* ((int64)SECS_PER_HOUR*USECS_PER_SEC)+`
`1628`	`1626`	`mins* ((int64)SECS_PER_MINUTE*USECS_PER_SEC)+`
`1629`		`-(int64)rint(secs*USECS_PER_SEC);`
	`1627`	`+(int64)secs;`
`1630`	`1628`	`#else`
`1631`	`1629`	`result->time=hours* (double)SECS_PER_HOUR+`
`1632`	`1630`	`mins* (double)SECS_PER_MINUTE+`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5d2adf0

File tree

1 file changed

1 file changed

`‎src/backend/utils/adt/timestamp.c`

0 commit comments