forked frompostgres/postgres
- Notifications
You must be signed in to change notification settings - Fork6
Commit5d28c9b
committed
Disable recheck_on_update optimization to avoid crashes.
The code added by commitc203d6c causes a crash in at least one case,where a potentially-optimizable expression index has a storage typedifferent from the input data type. A cursory code review turned upnumerous other problems that seem impractical to fix on short notice.Andres argued for revert of that patch some time ago, and if additionalsenior committers had been paying attention, that's likely what wouldhave happened, but we were not :-(At this point we can't just revert, at least not in v11, because that wouldmean an ABI break for code touching relcache entries. And we should notremove the (also buggy) support for the recheck_on_update index reloption,since it might already be used in some databases in the field. So thispatch just does the as-little-invasive-as-possible measure of disablingthe feature as though recheck_on_update were forced off for all indexes.I also removed the related regression tests (which would otherwise fail)and the user-facing documentation of the reloption.We should undertake a more thorough code cleanup if the patch can't befixed, but not under the extreme time pressure of being already overduefor 11.1 release.Per report from Ondřej Bouda and subsequent private discussion amongpgsql-release.Discussion:https://postgr.es/m/20181106185255.776mstcyehnc63ty@alvherre.pgsql1 parentc4f0876 commit5d28c9b
File tree
7 files changed
+6
-145
lines changed- doc/src/sgml
- ref
- src
- backend/utils/cache
- test/regress
- expected
- sql
7 files changed
+6
-145
lines changedLines changed: 2 additions & 35 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
356 | 356 |
| |
357 | 357 |
| |
358 | 358 |
| |
359 |
| - | |
360 |
| - | |
361 |
| - | |
362 |
| - | |
363 |
| - | |
364 |
| - | |
365 |
| - | |
366 |
| - | |
367 |
| - | |
368 |
| - | |
369 |
| - | |
370 |
| - | |
371 |
| - | |
372 |
| - | |
373 |
| - | |
374 |
| - | |
375 |
| - | |
376 |
| - | |
377 |
| - | |
378 |
| - | |
379 |
| - | |
380 |
| - | |
381 |
| - | |
382 |
| - | |
383 |
| - | |
384 |
| - | |
385 |
| - | |
386 |
| - | |
387 |
| - | |
388 |
| - | |
389 |
| - | |
390 |
| - | |
391 |
| - | |
392 |
| - | |
393 |
| - | |
| 359 | + | |
| 360 | + | |
394 | 361 |
| |
395 | 362 |
| |
396 | 363 |
| |
|
Lines changed: 0 additions & 13 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
1437 | 1437 |
| |
1438 | 1438 |
| |
1439 | 1439 |
| |
1440 |
| - | |
1441 |
| - | |
1442 |
| - | |
1443 |
| - | |
1444 |
| - | |
1445 |
| - | |
1446 |
| - | |
1447 |
| - | |
1448 |
| - | |
1449 |
| - | |
1450 |
| - | |
1451 |
| - | |
1452 |
| - | |
1453 | 1440 |
| |
1454 | 1441 |
| |
1455 | 1442 |
| |
|
Lines changed: 3 additions & 0 deletions
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
4755 | 4755 |
| |
4756 | 4756 |
| |
4757 | 4757 |
| |
| 4758 | + | |
4758 | 4759 |
| |
4759 | 4760 |
| |
4760 | 4761 |
| |
| |||
4800 | 4801 |
| |
4801 | 4802 |
| |
4802 | 4803 |
| |
| 4804 | + | |
| 4805 | + | |
4803 | 4806 |
| |
4804 | 4807 |
| |
4805 | 4808 |
| |
|
Lines changed: 0 additions & 64 deletions
This file was deleted.
Lines changed: 1 addition & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
84 | 84 |
| |
85 | 85 |
| |
86 | 86 |
| |
87 |
| - | |
| 87 | + | |
88 | 88 |
| |
89 | 89 |
| |
90 | 90 |
| |
|
Lines changed: 0 additions & 1 deletion
Original file line number | Diff line number | Diff line change | |
---|---|---|---|
| |||
99 | 99 |
| |
100 | 100 |
| |
101 | 101 |
| |
102 |
| - | |
103 | 102 |
| |
104 | 103 |
| |
105 | 104 |
| |
|
Lines changed: 0 additions & 31 deletions
This file was deleted.
0 commit comments
Comments
(0)