NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5d1e5c8

committed

Check for BuildIndexValueDescription returning NULL in gist_page_items

Per Coverity. BuildIndexValueDescription() cannot actually return NULL inthis instance, because it only returns NULL if the user doesn't have therequired privileges, and this function can only be used by superuser. Butbetter safe than sorry.

1 parent15251c0 commit5d1e5c8Copy full SHA for 5d1e5c8

File tree

1 file changed

-3

lines changed

contrib/pageinspect
- gistfuncs.c

1 file changed

-3

lines changed

`‎contrib/pageinspect/gistfuncs.c`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -247,14 +247,20 @@ gist_page_items(PG_FUNCTION_ARGS)`
`247`	`247`	`index_deform_tuple(itup,RelationGetDescr(indexRel),`
`248`	`248`	`itup_values,itup_isnull);`
`249`	`249`
`250`		`-key_desc=BuildIndexValueDescription(indexRel,itup_values,itup_isnull);`
`251`		`-`
`252`	`250`	`memset(nulls,0,sizeof(nulls));`
`253`	`251`
`254`	`252`	`values[0]=DatumGetInt16(offset);`
`255`	`253`	`values[1]=ItemPointerGetDatum(&itup->t_tid);`
`256`	`254`	`values[2]=Int32GetDatum((int)IndexTupleSize(itup));`
`257`		`-values[3]=CStringGetTextDatum(key_desc);`
	`255`	`+`
	`256`	`+key_desc=BuildIndexValueDescription(indexRel,itup_values,itup_isnull);`
	`257`	`+if (key_desc)`
	`258`	`+values[3]=CStringGetTextDatum(key_desc);`
	`259`	`+else`
	`260`	`+{`
	`261`	`+values[3]= (Datum)0;`
	`262`	`+nulls[3]= true;`
	`263`	`+}`
`258`	`264`
`259`	`265`	`tuplestore_putvalues(tupstore,tupdesc,values,nulls);`
`260`	`266`	`}`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5d1e5c8

File tree

1 file changed

1 file changed

`‎contrib/pageinspect/gistfuncs.c`

0 commit comments