NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5ccceb2

committed

Fix race condition in startup progress reporting.

Commit9ce346e added startupprogress reporting, but begin_startup_progress_phase has a racecondition: the timeout for the previous phase might fire justbefore we reschedule the interrupt for the next phase.To avoid the race, disable the timeout, clear the flag, and thenre-enable the timeout.Patch by me, reviewed by Nitin Jadhav.Discussion:https://postgr.es/m/CA+TgmoYq38i6iAzfRLVxA6Cm+wMCf4WM8wC3o_a+X_JvWC8bJg@mail.gmail.com

1 parent2f5c439 commit5ccceb2Copy full SHA for 5ccceb2

File tree

1 file changed

-0

lines changed

src/backend/postmaster
- startup.c

1 file changed

-0

lines changed

`‎src/backend/postmaster/startup.c`

Lines changed: 2 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -320,6 +320,8 @@ begin_startup_progress_phase(void)`
`320`	`320`	`if (log_startup_progress_interval==0)`
`321`	`321`	`return;`
`322`	`322`
	`323`	`+disable_timeout(STARTUP_PROGRESS_TIMEOUT, false);`
	`324`	`+startup_progress_timer_expired= false;`
`323`	`325`	`startup_progress_phase_start_time=GetCurrentTimestamp();`
`324`	`326`	`fin_time=TimestampTzPlusMilliseconds(startup_progress_phase_start_time,`
`325`	`327`	`log_startup_progress_interval);`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5ccceb2

File tree

1 file changed

1 file changed

`‎src/backend/postmaster/startup.c`

0 commit comments