NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5cb902e

committed

Explain dropdb can't use syscache because of TOAST

Add a comment explaining dropdb() can't rely on syscache. The issue withflattened rows was fixed by commit0f92b23, but better to havea clear explanation why the systable scan is necessary. The other placesdoing in-place updates on pg_database have the same comment.Suggestion and patch by Yugo Nagata. Backpatch to 12, same as the fix.Author: Yugo NagataBackpatch-through: 12Discussion:https://postgr.es/m/CAJTYsWWNkCt+-UnMhg=BiCD3Mh8c2JdHLofPxsW3m2dkDFw8RA@mail.gmail.com

1 parent4fdb655 commit5cb902eCopy full SHA for 5cb902e

File tree

1 file changed

-1

lines changed

src/backend/commands
- dbcommands.c

1 file changed

-1

lines changed

`‎src/backend/commands/dbcommands.c‎`

Lines changed: 3 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1790,7 +1790,9 @@ dropdb(const char *dbname, bool missing_ok, bool force)`
`1790`	`1790`	`pgstat_drop_database(db_id);`
`1791`	`1791`
`1792`	`1792`	`/*`
`1793`		`- * Update the database's pg_database tuple`
	`1793`	`+ * Get the pg_database tuple to scribble on. Note that this does not`
	`1794`	`+ * directly rely on the syscache to avoid issues with flattened toast`
	`1795`	`+ * values for the in-place update.`
`1794`	`1796`	`*/`
`1795`	`1797`	`ScanKeyInit(&scankey,`
`1796`	`1798`	`Anum_pg_database_datname,`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5cb902e

File tree

1 file changed

1 file changed

`‎src/backend/commands/dbcommands.c‎`

0 commit comments