NotificationsYou must be signed in to change notification settings
Fork6
Star31

Commit5c805d0

committed

Fix timestamp in end-of-recovery WAL records.

We used time(null) to set a TimestampTz field, which gave bogus results.Noticed while looking at pg_xlogdump output.Backpatch to 9.3 and above, where the fast promotion was introduced.

1 parent37de8de commit5c805d0Copy full SHA for 5c805d0

File tree

1 file changed

-2

lines changed

src/backend/access/transam
- xlog.c

1 file changed

-2

lines changed

`‎src/backend/access/transam/xlog.c`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -8076,7 +8076,7 @@ CreateEndOfRecoveryRecord(void)`
`8076`	`8076`	`if (!RecoveryInProgress())`
`8077`	`8077`	`elog(ERROR,"can only be used to end recovery");`
`8078`	`8078`
`8079`		`-xlrec.end_time=time(NULL);`
	`8079`	`+xlrec.end_time=GetCurrentTimestamp();`
`8080`	`8080`
`8081`	`8081`	`WALInsertLockAcquireExclusive();`
`8082`	`8082`	`xlrec.ThisTimeLineID=ThisTimeLineID;`
`@@ -8098,7 +8098,7 @@ CreateEndOfRecoveryRecord(void)`
`8098`	`8098`	`* changes to this point.`
`8099`	`8099`	`*/`
`8100`	`8100`	`LWLockAcquire(ControlFileLock,LW_EXCLUSIVE);`
`8101`		`-ControlFile->time= (pg_time_t)xlrec.end_time;`
	`8101`	`+ControlFile->time= (pg_time_t)time(NULL);`
`8102`	`8102`	`ControlFile->minRecoveryPoint=recptr;`
`8103`	`8103`	`ControlFile->minRecoveryPointTLI=ThisTimeLineID;`
`8104`	`8104`	`UpdateControlFile();`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5c805d0

File tree

1 file changed

1 file changed

`‎src/backend/access/transam/xlog.c`

0 commit comments